Skip to content

Fix AGP 9.0.0-alpha01 compatibility for compose resources#5385

Closed
simonlebras wants to merge 2 commits intoJetBrains:masterfrom
simonlebras:agp-kmp-variant
Closed

Fix AGP 9.0.0-alpha01 compatibility for compose resources#5385
simonlebras wants to merge 2 commits intoJetBrains:masterfrom
simonlebras:agp-kmp-variant

Conversation

@simonlebras
Copy link
Copy Markdown

AGP 9.0.0-alpha01 removed onVariant{} API from KMP Variant extension. (https://cs.android.com/android-studio/platform/tools/base/+/1d00038ec037fb04b4c83e0e0612ba6f0d35cc8b)

Replacement is the plural onVariants{} API

AGP 9.0.0-alpha01 removed onVariant{} API from KMP Variant extension.
@MatkovIvan MatkovIvan requested a review from terrakok August 18, 2025 09:15
gradle-download-plugin = "5.5.0"
kotlin-poet = "2.1.0"
plugin-android = "8.9.1"
plugin-android = "8.10.1"
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onVariants is only available with AGP 8.10+

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, how does it work if user uses AGP 8.9?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not compile unfortunately. It either does not work on 8.9 (with the fix) or on 9.0 (without the fix).

@terrakok terrakok closed this Aug 20, 2025
@terrakok terrakok reopened this Aug 20, 2025
@terrakok
Copy link
Copy Markdown
Member

#5391

@terrakok terrakok closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants