Fix critical typo#36
Merged
datdenkikniet merged 1 commit intoJoNil:masterfrom Oct 3, 2025
Merged
Conversation
BjornTheProgrammer
added a commit
to BjornTheProgrammer/elf2flash
that referenced
this pull request
Sep 23, 2025
Fixes [#36](JoNil/elf2uf2-rs#36), [#38](JoNil/elf2uf2-rs#38), [#40](JoNil/elf2uf2-rs#40), [#41](JoNil/elf2uf2-rs#41), [#42](JoNil/elf2uf2-rs#42) from `elf2uf2-rs`
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for taking the time to review this!
I made the pull request to add a termination signal a while back. I was implementing something for embassy when I just realized that I had written
\n\rinstead of the correct\r\n. This is extremely counter-intuitive and possibly breaks formatting in some terminals. Before possible adoption elsewhere, I recommend changing it.