Use log and env_logger#53
Merged
datdenkikniet merged 5 commits intoJoNil:masterfrom Oct 23, 2025
Merged
Conversation
datdenkikniet
requested changes
Oct 18, 2025
datdenkikniet
force-pushed
the
env-logger
branch
from
78ddc47 to
e045ba1
Compare
Contributor
Author
BjornTheProgrammer
left a comment
BjornTheProgrammer
left a comment
There was a problem hiding this comment.
Looks fantastic!
datdenkikniet
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using OPTS::global(), just use log and env_logger.
This approach also requires a reporter trait to be used, since we no longer globally detect deploy, but it makes this much more general