Skip to content

feat: add iterateTokens method#756

Merged
JoshuaKGoldberg merged 4 commits into
JoshuaKGoldberg:mainfrom
fisker:iterateTokens
Dec 27, 2025
Merged

feat: add iterateTokens method#756
JoshuaKGoldberg merged 4 commits into
JoshuaKGoldberg:mainfrom
fisker:iterateTokens

Conversation

@fisker

@fisker fisker commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

Part of #755, this one is unlike forEachComments, we only need yield tokens.
We can decide what to do with the comments in a follow-up pr.

@codecov

codecov Bot commented Sep 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.13%. Comparing base (e547759) to head (f0c5219).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   61.13%   61.13%           
=======================================
  Files          35       35           
  Lines        2923     2923           
  Branches      467      468    +1     
=======================================
  Hits         1787     1787           
  Misses       1136     1136           
Flag Coverage Δ
4.8.4 59.73% <100.00%> (ø)
latest 60.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fisker fisker mentioned this pull request Sep 29, 2025
3 tasks
@kirkwaiblinger

Copy link
Copy Markdown
Collaborator

I like this approach. Nice job on keeping the diff so minimal 👌

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Sorry for taking so long on this without explaining why - IIRC I'd wanted another person working on this package to take a look (and didn't want to leave them out of reviewing). Thanks for hopping on the review @kirkwaiblinger.

@JoshuaKGoldberg

Copy link
Copy Markdown
Owner

CI is very borked on main. Ignoring it.

@JoshuaKGoldberg JoshuaKGoldberg merged commit e2ca2a2 into JoshuaKGoldberg:main Dec 27, 2025
17 of 20 checks passed
@fisker fisker deleted the iterateTokens branch December 27, 2025 05:01
@JoshuaKGoldberg

Copy link
Copy Markdown
Owner

Released in ts-api-utils@2.2.0. 🚀 Thanks as always @fisker!

JoshuaKGoldberg added a commit that referenced this pull request Dec 28, 2025
<!-- 👋 Hi, thanks for sending a PR to ts-api-utils! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #755
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/ts-api-utils/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->

This contains change from #756, if we decide to add them one by one,
should merge #756 first.

---------

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants