feat: add iterateTokens method#756
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage 61.13% 61.13%
=======================================
Files 35 35
Lines 2923 2923
Branches 467 468 +1
=======================================
Hits 1787 1787
Misses 1136 1136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9d75aa0 to
a208135
Compare
|
I like this approach. Nice job on keeping the diff so minimal 👌 |
There was a problem hiding this comment.
Great! Sorry for taking so long on this without explaining why - IIRC I'd wanted another person working on this package to take a look (and didn't want to leave them out of reviewing). Thanks for hopping on the review @kirkwaiblinger.
|
CI is very borked on |
|
Released in |
<!-- 👋 Hi, thanks for sending a PR to ts-api-utils! 💖. Please fill out all fields below and make sure each item is true and [x] checked. Otherwise we may not be able to review your PR. --> ## PR Checklist - [x] Addresses an existing open issue: fixes #755 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/ts-api-utils/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/CONTRIBUTING.md) were taken ## Overview <!-- Description of what is changed and how the code change does that. --> This contains change from #756, if we decide to add them one by one, should merge #756 first. --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
PR Checklist
forEach...methods withIterables #755status: accepting prsOverview
Part of #755, this one is unlike
forEachComments, we only need yieldtokens.We can decide what to do with the comments in a follow-up pr.