feat: isStrictCompilerOptionEnabled should default to strict: true for TS 6#873
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
+ Coverage 61.86% 61.89% +0.03%
==========================================
Files 35 35
Lines 2989 2992 +3
Branches 473 475 +2
==========================================
+ Hits 1849 1852 +3
Misses 1140 1140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isStrictCompilerOptionEnabled should default to strict: true for TS 6
isStrictCompilerOptionEnabled should default to strict: true for TS 6isStrictCompilerOptionEnabled should default to strict: true for TS 6
This was referenced Mar 12, 2026
Merged
StyleShit
reviewed
Mar 15, 2026
RebeccaStevens
approved these changes
Mar 16, 2026
StyleShit
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Changes the way the options are resolved to make sure the strict options are enabled by default.
For the test infra, I've added
typescript@rcinto the test matrix in order to test TS 6. Once TS 6 is actually released,latestwill cover TS 6 and we can pin TS@5.9.3 to test the latest TS 5 version.