Skip to content

feat: isStrictCompilerOptionEnabled should default to strict: true for TS 6#873

Merged
kirkwaiblinger merged 4 commits into
mainfrom
ts-6-strict
Mar 19, 2026
Merged

feat: isStrictCompilerOptionEnabled should default to strict: true for TS 6#873
kirkwaiblinger merged 4 commits into
mainfrom
ts-6-strict

Conversation

@kirkwaiblinger

@kirkwaiblinger kirkwaiblinger commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

PR Checklist

Overview

Changes the way the options are resolved to make sure the strict options are enabled by default.

For the test infra, I've added typescript@rc into the test matrix in order to test TS 6. Once TS 6 is actually released, latest will cover TS 6 and we can pin TS@5.9.3 to test the latest TS 5 version.

@codecov

codecov Bot commented Mar 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.89%. Comparing base (c745c68) to head (6284ddb).
⚠️ Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
+ Coverage   61.86%   61.89%   +0.03%     
==========================================
  Files          35       35              
  Lines        2989     2992       +3     
  Branches      473      475       +2     
==========================================
+ Hits         1849     1852       +3     
  Misses       1140     1140              
Flag Coverage Δ
4.8.4 60.52% <100.00%> (+0.03%) ⬆️
latest 61.16% <100.00%> (+0.03%) ⬆️
rc 61.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger changed the title fix: isStrictCompilerOptionEnabled should default to strict: true fix: isStrictCompilerOptionEnabled should default to strict: true for TS 6 Mar 12, 2026
@kirkwaiblinger kirkwaiblinger changed the title fix: isStrictCompilerOptionEnabled should default to strict: true for TS 6 feat: isStrictCompilerOptionEnabled should default to strict: true for TS 6 Mar 12, 2026
This was referenced Mar 12, 2026
Comment thread src/compilerOptions.ts
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review March 15, 2026 17:01
@kirkwaiblinger kirkwaiblinger merged commit 4d6cc50 into main Mar 19, 2026
36 checks passed
@kirkwaiblinger kirkwaiblinger deleted the ts-6-strict branch March 19, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: TypeScript 6 support

3 participants