feat: drop CJS build, node 18 & typescript < 5.5#760
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #760 +/- ##
==========================================
- Coverage 61.46% 61.16% -0.31%
==========================================
Files 35 35
Lines 2948 2987 +39
Branches 473 468 -5
==========================================
+ Hits 1812 1827 +15
- Misses 1136 1160 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Welp, there are build failures in Node.js 18. ts-api-utils still supports 18 in the current major. We haven't discussed plans to release a new one to breaking-change drop support for Node.js 18. Is this a blocker?
|
This is because rolldown and tsdown do not support bundling in node 18, but his outputs will not be affected. Therefore, we need to find a way to test and run the outputs by tsdown in node18. |
|
👍 if you can figure that out, great! I haven't looked deeply. |
372ae44 to
edde608
Compare
|
I have refactored this PR to remove CJS support and Node.js 18 support. You can merge it when ready. |
|
@RebeccaStevens I see this as still blocked on the v1.0.0 stuff since it ups the minimum Node.js version from 18 to 20? |
PR Checklist
status: accepting prsOverview
tsup is not actively maintained anymore, migrating to new alternative tsdown.