Skip to content

feat: drop CJS build, node 18 & typescript < 5.5#760

Merged
RebeccaStevens merged 10 commits into
JoshuaKGoldberg:v3from
sxzz:feat/tsdown
Feb 24, 2026
Merged

feat: drop CJS build, node 18 & typescript < 5.5#760
RebeccaStevens merged 10 commits into
JoshuaKGoldberg:v3from
sxzz:feat/tsdown

Conversation

@sxzz

@sxzz sxzz commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

tsup is not actively maintained anymore, migrating to new alternative tsdown.

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@codecov

codecov Bot commented Oct 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.16%. Comparing base (181a947) to head (ea9aee9).
⚠️ Report is 2 commits behind head on v3.

Files with missing lines Patch % Lines
src/usage/UsageWalker.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3     #760      +/-   ##
==========================================
- Coverage   61.46%   61.16%   -0.31%     
==========================================
  Files          35       35              
  Lines        2948     2987      +39     
  Branches      473      468       -5     
==========================================
+ Hits         1812     1827      +15     
- Misses       1136     1160      +24     
Flag Coverage Δ
4.8.4 ?
5.5.4 61.16% <83.33%> (?)
latest 61.16% <83.33%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, there are build failures in Node.js 18. ts-api-utils still supports 18 in the current major. We haven't discussed plans to release a new one to breaking-change drop support for Node.js 18. Is this a blocker?

@sxzz

sxzz commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

This is because rolldown and tsdown do not support bundling in node 18, but his outputs will not be affected. Therefore, we need to find a way to test and run the outputs by tsdown in node18.

@JoshuaKGoldberg

Copy link
Copy Markdown
Owner

👍 if you can figure that out, great! I haven't looked deeply.

@sxzz sxzz marked this pull request as draft October 7, 2025 20:35
@sxzz sxzz force-pushed the feat/tsdown branch 2 times, most recently from 372ae44 to edde608 Compare October 21, 2025 10:21
@sxzz sxzz changed the title chore: migrate to tsdown feat: drop CJS build & node 18 Nov 25, 2025
@sxzz

sxzz commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

I have refactored this PR to remove CJS support and Node.js 18 support. You can merge it when ready.

@JoshuaKGoldberg

Copy link
Copy Markdown
Owner

@RebeccaStevens I see this as still blocked on the v1.0.0 stuff since it ups the minimum Node.js version from 18 to 20?

@RebeccaStevens RebeccaStevens changed the base branch from main to v3 February 24, 2026 05:51
@RebeccaStevens RebeccaStevens marked this pull request as ready for review February 24, 2026 06:04
@RebeccaStevens RebeccaStevens removed the request for review from JoshuaKGoldberg February 24, 2026 06:04
@RebeccaStevens RebeccaStevens changed the title feat: drop CJS build & node 18 feat: drop CJS build, node 18 & typescript < 5.5 Feb 24, 2026
@RebeccaStevens RebeccaStevens merged commit aaa62da into JoshuaKGoldberg:v3 Feb 24, 2026
23 checks passed
RebeccaStevens added a commit that referenced this pull request Mar 1, 2026
Co-authored-by: Kevin Deng <hi@sxzz.moe>
Co-authored-by: Rebecca Stevens <rebecca.stevens@outlook.co.nz>
fixes #761
fixes #764
fixes #712
RebeccaStevens added a commit that referenced this pull request Mar 1, 2026
Co-authored-by: Kevin Deng <hi@sxzz.moe>
Co-authored-by: Rebecca Stevens <rebecca.stevens@outlook.co.nz>
fixes #761
fixes #764
fixes #712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Migrate to tsdown

3 participants