prevent adding a method to the function >=#235
prevent adding a method to the function >=#235timholy merged 1 commit intoJuliaArrays:masterfrom nsajko:prevent_adding_methods_fix
>=#235Conversation
The generic fallback definition is always both correct and performant, relying on `<=`, so it is only harmful to add a method to `>=`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 7 7
Lines 673 673
=======================================
Hits 602 602
Misses 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test failures unrelated, see issue #234. |
|
Thanks! |
|
This PR greatly decreased the amount of sysimage invalidation on loading this package. The unique invalidation count upon Instructions to reproduce this result:
Data on each invalidation:
(Obviously most of this message is not meant for you, Tim Holy, specifically. Just being thorough.) |
The generic fallback definition is always both correct and performant, relying on
<=, so it is only harmful to add a method to>=.