Skip to content

Implement indexing by value with atvalue #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timholy merged 10 commits into from
Jul 6, 2017
Merged

Implement indexing by value with atvalue #52

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
36ff77a
Implement indexing by value with atvalue
ajkeller34 Jun 28, 2017
3267a55
Tighten up Idx, add docs for atvalue, add tests
ajkeller34 Jun 28, 2017
0242ee4
Address review comments
ajkeller34 Jun 28, 2017
6e99a30
Add options for tolerance
ajkeller34 Jun 29, 2017
9ba355f
Add ability to throw a BoundsError with value index
ajkeller34 Jul 3, 2017
94671bf
Mark a test as broken for Julia 0.5.2 only.
ajkeller34 Jul 4, 2017
5073684
Minor docs tweaks, bump Unitful version in test/REQUIRE, small change…
ajkeller34 Jul 6, 2017
c769962
Fix typo in a test due to character encodings
ajkeller34 Jul 6, 2017
53a5f88
Fix typo in README
ajkeller34 Jul 6, 2017
dba7370
Fix Julia 0.5 complaint
ajkeller34 Jul 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/indexing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,4 +193,10 @@ A = AxisArray(OffsetArrays.OffsetArray([1 2; 3 4], 0:1, 1:2),
@test_throws ArgumentError A[4.0]
@test_throws ArgumentError A[BigFloat(1.0)]
@test_throws ArgumentError A[1.0f0]
@test_throws ArgumentError A[:,6.1]
if VERSION == v"0.5.2"
# Cannot compose @test_broken with @test_throws (Julia #21098)
# A[:,6.1] incorrectly throws a BoundsError instead of an ArgumentError on Julia 0.5.2
Copy link
Copy Markdown

@tkelman tkelman Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did anyone bisect this?

Copy link
Copy Markdown
Member

@mbauman mbauman Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't bisect it, but I'm quite certain that it was JuliaLang/julia#19730. We used to check bounds with < before converting indices. Now we convert indices first. This is expected.

Copy link
Copy Markdown

@tkelman tkelman Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh? how, this is a problem only on 0.5.2 apparently?

Copy link
Copy Markdown

@tkelman tkelman Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would show up as a package regression if I make an 0.5.3, so I'd like to figure out what caused this and whether it was something that should not have been backported

@test_broken A[:,6.1]
else
@test_throws ArgumentError A[:,6.1]
end
⚡