Indexing by an array of values#97
Merged
ajkeller34 merged 2 commits intoJuliaArrays:masterfrom Aug 13, 2017
Merged
Conversation
Collaborator
Author
|
Hmm, I guess this doesn't work on 0.5. The failures are related to the broadcasting changes in 0.6, so this is blocked until 0.5 support is dropped for AxisArrays. |
Member
|
I have no reservations about dropping 0.5 now, though perhaps we should finish & merge #90 (and then tag) first? |
Collaborator
Author
|
I'm in no hurry to merge this. I'm not sure what is left to do in #90 (seems like requiring 0.6 is the simplest solution?) but let me know if I can help somehow. |
Member
|
#102 has been merged, so the way is clear here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #52 has been merged, this PR attempts to address #84, except for the "by default" part. Simply broadcast
atvalue:With many dimensions, I concede that typing
atvaluerepeatedly might become tiresome. Perhaps in some follow-up PR I might implement a macro (@value?) for splicingatvaluerepeatedly into an expression if a user wants to index all dimensions by value. I would guess that should be possible though I haven't tried or thought too deeply about it.