[BREAKING] Make DataFrameColumns stop being an AbstractVector#2291
[BREAKING] Make DataFrameColumns stop being an AbstractVector#2291bkamins merged 13 commits intoJuliaData:masterfrom
Conversation
|
@nalimilan - it should be good to have a look at. |
|
As usual some corner cases of the changes popped up. |
quinnj
left a comment
There was a problem hiding this comment.
LGTM; just the use of [begin] causing 1.0 test failures
|
Thank you for having a look at it! |
|
This looks great! |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
|
@nalimilan - your questions were exactly the things I had to check against Base when implementing it. These interfaces are really non-obvious. |
|
So the major point of discussion is this case: As you can see - I have implemented methods to follow what happens in Base with vectors. We can change it to follow your proposal though. What do you think? |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
|
OK, makes sense. Then the only remaining issue to settle is whether to create a |
|
You convinced me to return a |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
|
Thank you! |
Fixes #2229
I have added functionalities for
DataFrameColumnsthat I find useful, but please comment if you would like to see more.