make GroupKey API more consistent#2308
Merged
bkamins merged 4 commits intoJuliaData:masterfrom Aug 2, 2020
Merged
Conversation
bkamins
changed the title
nalimilan
reviewed
Jul 7, 2020
| Instances of this type are returned by `keys(::GroupedDataFrame)` and are not | ||
| meant to be constructed directly. | ||
|
|
||
| Indexing is one-dimensional like specifying a column of a `DataFrame`. |
Member
There was a problem hiding this comment.
I don't understand the "like" part.
Member
Author
There was a problem hiding this comment.
I have copied it from DataFrameRow docstring, so we should fix it also there. It is meant that the rules are the same as for the second dimension in data frame. How do you think we could phrase it?
Member
There was a problem hiding this comment.
OK. Maybe something about accepted index types?
Member
Author
|
@nalimilan - I have updated the docstring |
Member
Author
|
Only coverage fails |
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Member
Author
|
Thank you! |
bkamins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing methods for
GroupKeyto make it consistent withDataFrameRowwhich is similar.See #2305 for discussion. CC @goretkin.
Also this should be made consistent with #2281 whichever gets merged first. CC @pdeffebach
After this PR and #2281 another one with
==,isequal,inetc. definitions should be done.I hope I have not missed any definitions - could you please check? Thank you!