[BREAKING] Deprecate dataframe bang#2338
Conversation
|
@nalimilan - do you have any take on this? I think it is OK to remove |
src/deprecated.jl
Outdated
| @deprecate map(f::Pair, gd::GroupedDataFrame) combine(AsTable(first(f)) => last(f), gd, ungroup=false) | ||
|
|
||
| @deprecate DataFrame!(args...; kwargs...) begin | ||
| if :copycols in keys(kwargs) |
There was a problem hiding this comment.
Isn't this going to be printed too? I think you need to call depwarn manually. Or just drop this check, people will get an error anyway.
There was a problem hiding this comment.
it is going to be printed. If we remove it then we change the behavior of DataFrame! in some corner cases. The issue is that when someone writes DataFrame!(..., copycols=false) with depwarn you will get:
- a warning to use
copycols=false - an error that you are not allowed to pass
copycols=false
But now as I think of it - I can put depwarn after the error and it will be OK. I will change it
There was a problem hiding this comment.
I the end I decided to skip the error part as it threw error earlier in order to bet a cleaner deprecation.
|
should be good now. |
|
only Coverage fails |
|
Thank you! |
3 participants
Fixes #2317