[BREAKING] Return 0 missing count for columns of nonmissing type#2360
Merged
bkamins merged 3 commits intoJuliaData:masterfrom Aug 13, 2020
Merged
[BREAKING] Return 0 missing count for columns of nonmissing type#2360bkamins merged 3 commits intoJuliaData:masterfrom
bkamins merged 3 commits intoJuliaData:masterfrom
Conversation
bkamins
reviewed
Aug 11, 2020
bkamins
approved these changes
Aug 11, 2020
Member
bkamins
left a comment
There was a problem hiding this comment.
Looks good apart for the new file that should not land here. In the past the distinction was required, but recently we started to show full eltype (rather than stripped one as we did in the past).
Added by accident - thanks VSCode!!!
Member
|
As a general note:
Thank you for the PR. |
nalimilan
approved these changes
Aug 13, 2020
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up on Slack - as the
eltypeis printed in the returned table, there's little additional information in returningnothing, as the user can see fromeltypewhether the columns allowsmissingor not. Returning 0 here makes sorting the table on this column easier.