Merged
Conversation
Member
|
Thanks, looks good. I still think it would be nice to support this everywhere, but indeed it will require a deeper refactoring. Could you update the |
Member
Author
|
I updated |
Contributor
|
This is great! Love that we have |
Member
Author
|
Now the deprecation of |
nalimilan
approved these changes
Sep 5, 2020
Member
nalimilan
left a comment
There was a problem hiding this comment.
Yeah, it's nice that the deprecation is reasonable. That also means many similar operations are now quite easy to do.
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2395
Now I understand why I have not added it in the past -
AbstractIndexis not aware of column types.Therefore I propose to add this option to
namesonly. This is useful on its own right. In other places one will have to write something likedf[:, names(df, Int)]which is a bit verbose, but not that bad. The benefits are twofold:MultiColumnIndex, as we cannot just extendMultiColumnIndexwithType)