[BREAKING] deprecate name => fun in favor of fun => name in describe

[bkamins]

Fixes #2385

[nalimilan]

Looks good with fixed indentation!

[bkamins]

@matthieugomez - what I changed here is what we all agree to change.

Now - do you have strong preference for your proposal? If yes, just to make sure, you envision the signature to be:

describe(df, cols=:; stats=[:mean, :min, :median, :max, :nmissing, :eltype])

where stats is a single stat or a vector of statistics to calculate?

(if we are breaking things I would not oppose this that much, but I want to make sure that your proposal has the general support)

[matthieugomez]

I would prefer it but it's not the hill I'm ready to die on ;) It's interesting to hear you were using it in a different way.

…

On Mon, Aug 31, 2020 at 10:20 AM Bogumił Kamiński ***@***.***> wrote: @matthieugomez <https://github.com/matthieugomez> - what I changed here is what we all agree to change. Now - do you have strong preference for your proposal? If yes, just to make sure, you envision the signature to be: describe(df, cols=:; stats=[:mean, :min, :median, :max, :nmissing, :eltype]) where stats is a single stat or a vector of statistics to calculate? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2401 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPPPXPI6I2OHRPXT4L6FO3SDPLXTANCNFSM4QQQQACQ> .

[bkamins]

@nalimilan - do you have any preference here?

[nalimilan]

I don't have a strong opinion. At least what is clear is that functions which take a cols (positional) argument only allow a single one in general, but functions that take source => fun => dest allow varargs. So in that sense the current situation is consistent.

[bkamins]

Thank you for considering it with such care. Given all pros and cons I am leaning to leave the PR as it stands now.

[bkamins]

@nalimilan - so do we go for this or wait a bit for more feedback (I feel all has been said already).

[nalimilan]

Yeah, let's go with this since there's no perfect solution.

[bkamins]

Thank you!