Merged
Conversation
ararslan
reviewed
Sep 22, 2020
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Member
Author
|
only coverage and nightly fails now |
ararslan
reviewed
Sep 23, 2020
Co-authored-by: Alex Arslan <ararslan@comcast.net>
ararslan
approved these changes
Sep 23, 2020
Member
ararslan
left a comment
ararslan
left a comment
There was a problem hiding this comment.
I was wanting this just yesterday! 😄
Member
Author
|
@nalimilan - OK to merge? |
nalimilan
approved these changes
Sep 24, 2020
| export hasproperty | ||
| end | ||
|
|
||
| if isdefined(Base, :only) # Introduced in 1.4.0 |
Member
There was a problem hiding this comment.
I don't to prefer explicit VERSION checks, which Femtocleaner can automatically remove once we drop support for 1.4, but as you like.
Member
Author
|
Thank you! I leave it as is. When we will move to a new LTS I will have to review the whole package anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion on Slack I think it is good to add
onlyto complementfirstandlast.