Skip to content

remove deprecations for 1.0 release#2679

Merged
bkamins merged 4 commits intomainfrom
bk/remove_deprecations
Mar 28, 2021
Merged

remove deprecations for 1.0 release#2679
bkamins merged 4 commits intomainfrom
bk/remove_deprecations

Conversation

@bkamins
Copy link
Copy Markdown
Member

@bkamins bkamins commented Mar 25, 2021

No description provided.

@bkamins bkamins added this to the 1.0 milestone Mar 26, 2021
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Mar 26, 2021

re-trigger CI, as on nightly strange OutOfMemory error happens in multi-threaed code that I cannot reproduce

@bkamins bkamins closed this Mar 26, 2021
@bkamins bkamins reopened this Mar 26, 2021
@bkamins bkamins requested a review from nalimilan March 27, 2021 11:12
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Mar 27, 2021

This out-of-memory error https://github.com/JuliaData/DataFrames.jl/pull/2679/checks?check_run_id=2209199932 randomly happens on nightly.

@nalimilan - to whom do you think we should report it? It is related to multi-threading.

@nalimilan
Copy link
Copy Markdown
Member

Maybe it's just that the VM has a limited amount of RAM? We didn't had tests with several million rows until recently. We could use 3 or even 2 columns instead of 4 there.

@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Mar 28, 2021

OK. I will merge this and open a PR reducing the memory use.

@bkamins bkamins merged commit 73ca8f1 into main Mar 28, 2021
@bkamins bkamins deleted the bk/remove_deprecations branch March 28, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants