Alignment of complex numbers

[ronisbr]

Hi!

This PR should fix #2754 . However, it adds somewhat complex regexes, which can decrease performance, and have some corner case that I did not think of. Thus, I need help testing this algorithm :)

[ronisbr]

Oops, I need to fix an overflow in the tests.

[strickek]

In "very_big_column_name_4" there should also be a test case with negative real part.
I think the '|' in the REGEX of alignment_regex_complex (line 200) can be deleted (no need to match for this Char).

[ronisbr]

In "very_big_column_name_4" there should also be a test case with negative real part.
I think the '|' in the REGEX of alignment_regex_complex (line 200) can be deleted (no need to match for this Char).

Good catch! I have updated the code. Let's see if the test passes.

[bkamins]

@nalimilan - can you please have a quick look if you agree with the rules used?

[nalimilan]

Makes sense. Just a few style comments.

(Ideally I would say that in addition to aligning on the sign of the imaginary parts, the real parts should be aligned like real numbers, and imaginary parts should be aligned like real numbers, but Base doesn't do this either since that would require adding spaces in the middle of the number...)

[ronisbr]

(Ideally I would say that in addition to aligning on the sign of the imaginary parts, the real parts should be aligned like real numbers, and imaginary parts should be aligned like real numbers, but Base doesn't do this either since that would require adding spaces in the middle of the number...)

Yes, this would be good but involve some changes in PrettyTables.jl. What we need to implement is the support for multiple anchors, so that we can have multiple alignments. It is not an easy task.

I think I resolved all @nalimilan's comments!

[bkamins]

It is not an easy task.

This is what I would imagine. I would leave it for later. I think we have more pivotal functionalities (like HTML/LaTeX support) that should get a higher priority.

[bkamins]

@ronisbr - OK to merge?

[ronisbr]

Yes!

[bkamins]

Thank you!