move summary outside of a <table> in text/html#2801
Merged
Conversation
Member
|
I trust you that this looks nice? :-) |
nalimilan
reviewed
Jun 24, 2021
Member
Author
|
I did not have time to fix CI yet (to many things in parallel). I opened the PR to let #2800 verify if the tags/classes are as expected. I will finalize it soon. |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Member
Author
|
@nalimilan - this should be good to merge. I have re-written the tests and also tested under Jupyter Notebook. @jkrumbiegel - checking if what we have here follows your expectations would be welcome. Thank you! |
Contributor
|
Looking at the code, I think this is good. The outer div can also help when making the table scroll inside the div, in case it's too wide. This is weird to do in css if you only have the table. |
nalimilan
approved these changes
Jun 28, 2021
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2800