Skip to content

move summary outside of a <table> in text/html#2801

Merged
bkamins merged 6 commits intomainfrom
bkamins-patch-1
Jun 28, 2021
Merged

move summary outside of a <table> in text/html#2801
bkamins merged 6 commits intomainfrom
bkamins-patch-1

Conversation

@bkamins
Copy link
Copy Markdown
Member

@bkamins bkamins commented Jun 23, 2021

Fixes #2800

@nalimilan
Copy link
Copy Markdown
Member

I trust you that this looks nice? :-)
(CI is failing)

@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Jun 24, 2021

I did not have time to fix CI yet (to many things in parallel). I opened the PR to let #2800 verify if the tags/classes are as expected. I will finalize it soon.

@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Jun 26, 2021

@nalimilan - this should be good to merge. I have re-written the tests and also tested under Jupyter Notebook.

@jkrumbiegel - checking if what we have here follows your expectations would be welcome. Thank you!

@jkrumbiegel
Copy link
Copy Markdown
Contributor

jkrumbiegel commented Jun 26, 2021

Looking at the code, I think this is good. The outer div can also help when making the table scroll inside the div, in case it's too wide. This is weird to do in css if you only have the table.

@bkamins bkamins merged commit 764540b into main Jun 28, 2021
@bkamins bkamins deleted the bkamins-patch-1 branch June 28, 2021 09:52
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Jun 28, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

html dataframe representation includes invalid placement of <p> tag

3 participants