Skip to content

add Tables.materializer for types methods#2839

Merged
bkamins merged 1 commit intomainfrom
bk/materializer
Aug 25, 2021
Merged

add Tables.materializer for types methods#2839
bkamins merged 1 commit intomainfrom
bk/materializer

Conversation

@bkamins
Copy link
Copy Markdown
Member

@bkamins bkamins commented Aug 12, 2021

Fixes #2833

Implement Tables.materializer on types rather than on values, as when passed values it will fall back to types anyway.

@bkamins bkamins merged commit fe7709d into main Aug 25, 2021
@bkamins bkamins deleted the bk/materializer branch August 25, 2021 14:51
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Aug 25, 2021

Thank you!

@quinnj - I assume you were OK with this change?

@quinnj
Copy link
Copy Markdown
Member

quinnj commented Aug 25, 2021

Yes, this looks good by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement Tables.materializer(::Type{<:AbstractDataFrame})?

3 participants