Skip to content

make DataFrame constructor more flexible#2859

Merged
bkamins merged 5 commits intomainfrom
bk/more_flexible_constructor
Sep 7, 2021
Merged

make DataFrame constructor more flexible#2859
bkamins merged 5 commits intomainfrom
bk/more_flexible_constructor

Conversation

@bkamins
Copy link
Copy Markdown
Member

@bkamins bkamins commented Sep 5, 2021

Fixes #2858

@bkamins bkamins requested a review from nalimilan September 5, 2021 21:57
@bkamins bkamins added the feature label Sep 5, 2021
@bkamins bkamins added this to the 1.3 milestone Sep 5, 2021
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Sep 5, 2021

As usual with dispatch it is more tricky than it seems, but I hope all is good 😄.

@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Sep 6, 2021

The CI failure is Out of Memory error - re-triggering just to make sure all is OK.

@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Sep 6, 2021

@nalimilan - I have added the copycols kwarg support for matrix constructor. Can you please re-review the PR? Thank you!

Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Sep 6, 2021

OK to merge after CI passes?

@bkamins bkamins merged commit 1a6fd15 into main Sep 7, 2021
@bkamins bkamins deleted the bk/more_flexible_constructor branch September 7, 2021 05:30
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Sep 7, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow DataFrame(matrix, names, copycols=false) Support the Case of Matrix{Any} as Data and Vector{Any} as Header

2 participants