Allow passing multiple columns to subset#2926
Conversation
|
@nalimilan - can you please re-review. I have forgotten to add NEWS.md entry + update documentation. I have also added a clear explanation that |
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
|
I have updated the docs following your suggestions. |
| for working with tabular data. In DataFrames.jl the `DataFrame` and | ||
| `SubDataFrame` types are subtypes of `AbstractDataFrame`. |
There was a problem hiding this comment.
I'd put this after the sentence below which gives the overall definition.
|
|
||
| This method is defined so that DataFrames.jl implements the Julia API for | ||
| collections, but it is generally recommended to use the [`subset!`](@ref) | ||
| function instead, as it is both faster and more consistent with other |
There was a problem hiding this comment.
Actually I forgot that you could pass cols here to ensure type stability, and subset isn't faster in that case, right? Maybe we should only mention consistency?
Also, I'd only mention this at the end of the docstring, possibly in a !!! note. Better not add too much noise for people who do want to use that function.
There was a problem hiding this comment.
changed all docstrings for filter and subset and the manual entry.
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
|
Thank you! |
2 participants
Fixes #2924