plan for a change in broadcasting rules in Julia 1.7#2937
Merged
Conversation
Member
Author
|
For a reference. The current behavior is: and after the change both operations will produce the expected result described in the comment under Julia 1.7 and newer. Under Julia 1.6 and older they will remain as they are now as it is impossible to fix this behavior there. |
nalimilan
approved these changes
Nov 14, 2021
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
bkamins
commented
Nov 14, 2021
bkamins
commented
Nov 14, 2021
bkamins
commented
Nov 14, 2021
| # TODO: remove the deprecation in DataFrames.jl 1.4 release | ||
| Base.depwarn("In the 1.4 release of DataFrames.jl this operation will allocate a new column " * | ||
| "instead of performing an in-place assignment. " | ||
| "To perform an in-place assignment use `df[:, col] .= ...` instead.", |
Member
Author
There was a problem hiding this comment.
this is what I would recommend.
nalimilan
approved these changes
Nov 14, 2021
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a transition PR clearly communicating to users what will happen in DataFrames.jl 1.4 release, see #2804.
Since the change planned in DataFrames.jl 1.4 will be mildly breaking and will introduce an inconsistency between Julia versions an additional transition period is I think a good approach.