Implementation of eachindex, proprow, and groupindices#3001
Merged
Conversation
Member
Author
|
@nalimilan - this PR should be ready for review. As usual - can you please fix the "language issues" 😄 (in several places I was not sure what the best wording would be). |
nalimilan
reviewed
Feb 12, 2022
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Co-authored-by: Milan Bouchet-Valat <[email protected]>
bkamins
commented
Feb 13, 2022
Member
Author
|
CI failure is unrelated |
nalimilan
reviewed
Feb 14, 2022
Contributor
|
Looks great to me! I appreciate this feature. It really puts us on par with Stata. Works just fine with DataFramesMeta. Tough (very) long term it would be nice to do something like but I understand the limitations and think this feature is very good. |
pdeffebach
approved these changes
Feb 15, 2022
Member
Author
|
@nalimilan - any more thoughts on this PR (no need to rush - I know it is complex) |
nalimilan
approved these changes
Feb 17, 2022
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2556.
I have finished the core implementation of the agreed PR. Hopefully the PR is relatively easy to review (I managed to make the changes "local" only - not requiring rewriting the logic of processing).