Conversation
jariji
reviewed
Dec 5, 2022
Contributor
|
I favor |
Member
Author
|
OK. I have changed kwarg to |
Member
Author
|
also fixes #3247 |
nalimilan
reviewed
Dec 17, 2022
nalimilan
approved these changes
Dec 23, 2022
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2753
The performance probably can be improved in some cases, but I wanted to start with something simple that works (and already has performance that is not horrible).
I proposed the
sortkwarg to specify sorting order, but maybe some other name would be better (earlier we discussedorder).