Skip to content

Allow to pass multiple predicates in Cols and mix them with other selectors#3279

Merged
bkamins merged 3 commits intomainfrom
bk/flexible_cols
Feb 5, 2023
Merged

Allow to pass multiple predicates in Cols and mix them with other selectors#3279
bkamins merged 3 commits intomainfrom
bk/flexible_cols

Conversation

@bkamins
Copy link
Copy Markdown
Member

@bkamins bkamins commented Feb 2, 2023

Fixes issue raised on Slack.

I do not remember why we have not added support for it from the start, but I do not see the reason to disallow selectors like:

df[:, Cols(startswith("a"), endswith("2"))]

@bkamins bkamins requested a review from nalimilan February 2, 2023 15:12
@bkamins bkamins added this to the 1.5 milestone Feb 2, 2023
@bkamins bkamins added the feature label Feb 2, 2023
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Feb 2, 2023

Potentially related is #3034 (but I do not think we are going to implement it).

@bkamins bkamins merged commit 3368d85 into main Feb 5, 2023
@bkamins bkamins deleted the bk/flexible_cols branch February 5, 2023 07:34
@bkamins
Copy link
Copy Markdown
Member Author

bkamins commented Feb 5, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants