Merged
Conversation
bkamins
reviewed
Mar 17, 2023
Member
|
Looks good apart from |
Member
|
also can you please add NEWS.md entry for 1.6 release (see #3302 how it should look)? |
alecloudenback
force-pushed
the
describe_sum
branch
from
78e6fbc to
0d2692e
Compare
Contributor
Author
|
Feedback is incorporated. |
Member
|
Thank you. I updated tests a bit. Once CI passes I will merge the PR. |
bkamins
approved these changes
Apr 28, 2023
Member
|
Approved. Let us wait a few days to see if other maintiners want to comment. CC @nalimilan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sumtotal is a useful descriptive statistic for a lot of data analysis and seems as worth as the other built-in options and makingdesribemore immediately useful for many fields (e.g. finance, economics, demographics, etc).