Conversation
storopoli
left a comment
storopoli
left a comment
There was a problem hiding this comment.
Some comments on the docstring.
As ever, amazing work!
| time). Whether or not tasks are actually spawned and their number are | ||
| determined automatically. Set to `false` if `combine` requires serial | ||
| execution or is not thread-safe. | ||
| - `sortrows`: the order of rows in the output table; all values accepted by |
There was a problem hiding this comment.
| - `sortrows`: the order of rows in the output table; all values accepted by | |
| - `sortrows`: the order of rows in the resulting table; all values accepted by |
I prefer something else than "output", I find it a little ambiguous.
| - `sortrows`: the order of rows in the output table; all values accepted by | ||
| `sort` keyword argument in `groupby` passed the `rowkeys` for grouping are supported; | ||
| `false` by default (rows are ordered following the first appereance order). | ||
| - `sortcols`: the order of columns in the output table; all values accepted by |
There was a problem hiding this comment.
| - `sortcols`: the order of columns in the output table; all values accepted by | |
| - `sortcols`: the order of columns in the resulting table; all values accepted by |
I prefer something else than "output", I find it a little ambiguous.
| determined automatically. Set to `false` if `combine` requires serial | ||
| execution or is not thread-safe. | ||
| - `sortrows`: the order of rows in the output table; all values accepted by | ||
| `sort` keyword argument in `groupby` passed the `rowkeys` for grouping are supported; |
| `sort` keyword argument in `groupby` passed the `rowkeys` for grouping are supported; | ||
| `false` by default (rows are ordered following the first appereance order). | ||
| - `sortcols`: the order of columns in the output table; all values accepted by | ||
| `sort` keyword argument in `groupby` passed `colkey` for grouping are supported; |
| Note that the ordering is done on the source data (not on column final column names | ||
| that can be potentially changed by the function passed in the `renamecols` keyword argument). |
There was a problem hiding this comment.
This is also confusing.
"column final column names"
|
@storopoli - thank you for the comments. @nalimilan - before I move forward could you please comment if you like this addition. (I would want to have a decision on this PR and a few more and make a release in 1Q2024 of DataFrames.jl, especially that Julia 1.10 is coming and we need to clean up Project.toml in light of the change how standard library packages will be handled there) |
|
It seems to is not merged yet. Would be nice to have sorting for |
3 participants
Fixes #3334
Tests are missing, but I would like to get feedback if we like the design before I move forward.
This is useful as the order of appearance is often not wanted. And it is impossible to ensure wanted sort order of rows and columns in the source. Finally, especially for columns - it is especially useful if you have ordered categorical values to present (so you can sort data e.g. by day of week, which is lost after you created the output since column names are
Symbolthen)