use same cpu target as currrent sysimage on 1.13+#1096
use same cpu target as currrent sysimage on 1.13+#1096KristofferC wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1096 +/- ##
=======================================
Coverage 85.59% 85.59%
=======================================
Files 3 3
Lines 826 826
=======================================
Hits 707 707
Misses 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| const NATIVE_CPU_TARGET = "native" | ||
| const DEFAULT_SYSIMAGE_CPU_TARGET = @static if VERSION >= v"1.13-" | ||
| Sys.sysimage_target() |
There was a problem hiding this comment.
Should we use "sysimage"? I thought that was a new alias for this in 1.13, IIRC
There was a problem hiding this comment.
I am a bit confused that this doesn't align with default_app_cpu_target() though
There was a problem hiding this comment.
I am a bit confused that this doesn't align with default_app_cpu_target() though
What do you mean? If you mean why app cpu target does not align with "sysimage" it is because you probably want to distribute an app with a wider cpu target than "native" even if you use a locally built julia (that probably defaulted to native)? But maybe you mean something else.
2 participants
No description provided.