Conversation
Member
|
+10000 Works locally here! |
yuyichao
approved these changes
May 23, 2017
Contributor
yuyichao
left a comment
yuyichao
left a comment
There was a problem hiding this comment.
Note that this actually doesn't have any performance advantage, only smaller allocation count since we count realloc differently than free and alloc, even though the latter is actually what's happening....
Contributor
|
Would be nice to add the test for the bug. |
Contributor
|
#22196 opened to add a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #22021