Fix DomainError when parsing DateTime#22198
Merged
KristofferC merged 2 commits intomasterfrom Jun 5, 2017
Merged
Conversation
KristofferC
added
backport pending 0.6
bugfix
quinnj
approved these changes
Jun 2, 2017
fredrikekre
reviewed
Jun 2, 2017
| # Issue #21504 | ||
| @test isnull(tryparse(Dates.Date, "0-1000")) | ||
|
|
||
| # Issue #22100 |
Member
There was a problem hiding this comment.
Perhaps make a testset of this issue tests? Simplifies for whoever converts this file to @testsets later on
Member
Author
There was a problem hiding this comment.
That sounds resasonable to me
Member
Author
|
32-bit failure on Appveyor is unrelated. Should I trigger a new build? |
Member
|
I don't think that is needed. |
tkelman
pushed a commit
that referenced
this pull request
Jun 6, 2017
* Fix DomainError when parsing DateTime * Converted tests into a testset (cherry picked from commit abf3bce)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22100