add a vibe coded `Test.detect_closure_boxes` for closure boxes in loaded code by KristofferC · Pull Request #60478 · JuliaLang/julia

KristofferC · 2025-12-25T14:00:36Z

For example:

❯ ./julia contrib/scan-closure-boxes.jl --module=LibGit2
mod=LibGit2     var=branch_ref  func=#branch!#94        sig=Tuple{LibGit2.var"##branch!#94", AbstractString, Bool, Bool, typeof(LibGit2.branch!), LibGit2.GitRepo, AbstractString, AbstractString}   file=/Users/kc/julia/usr/share/julia/stdlib/v1.14/LibGit2/src/LibGit2.jl     line=416
mod=LibGit2     var=head_name   func=#checkout!#110     sig=Tuple{LibGit2.var"##checkout!#110", Bool, typeof(LibGit2.checkout!), LibGit2.GitRepo, AbstractString}    file=/Users/kc/julia/usr/share/julia/stdlib/v1.14/LibGit2/src/LibGit2.jl     line=506

and indeed:

julia> code_warntype(Tuple{LibGit2.var"##branch!#94", AbstractString, Bool, Bool, typeof(LibGit2.branch!), LibGit2.GitRepo, AbstractString, AbstractString})
MethodInstance for LibGit2.var"#branch!#94"(::AbstractString, ::Bool, ::Bool, ::typeof(LibGit2.branch!), ::GitRepo, ::AbstractString, ::AbstractString)
  from var"#branch!#94"(track::AbstractString, force::Bool, set_head::Bool, ::typeof(LibGit2.branch!), repo::GitRepo, branch_name::AbstractString, commit::AbstractString) @ LibGit2 ~/julia/usr/share/julia/stdlib/v1.14/LibGit2/src/LibGit2.jl:416
Arguments
  #branch!#94::Core.Const(LibGit2.var"#branch!#94")
  track::AbstractString
...
  branch_ref@_16::Core.Box <--------

KristofferC · 2025-12-25T15:38:24Z

Not sure if this is obvious or not, but can (of course) be used with external packages as well:

~/JuliaPkgs/DataFrames.jl
❯ ~/julia/julia --project ~/julia/contrib/scan-closure-boxes.jl --module=DataFrames 
mod=DataFrames  var=newparent   func=_combine_prepare_norm      sig=Tuple{typeof(DataFrames._combine_prepare_norm), DataFrames.GroupedDataFrame, Vector{Any}, Vararg{Bool, 6}}       file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl     line=56
mod=DataFrames  var=outcol      func=_combine_process_proprow   sig=Tuple{typeof(DataFrames._combine_process_proprow), Ref{Any}, Bool, DataFrames.AbstractDataFrame, DataFrames.GroupedDataFrame, Dict{Symbol, Tuple{Bool, Int64}}, Vector{DataFrames.TransformationResult}, Vector{Int64}}       file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl     line=286
mod=DataFrames  var=right_ixs   func=compose_inner_table        sig=Tuple{typeof(DataFrames.compose_inner_table), DataFrames.DataFrameJoiner, Bool, Union{AbstractString, Function, Symbol}, Union{AbstractString, Function, Symbol}, Symbol}     file=/Users/kc/JuliaPkgs/DataFrames.jl/src/join/composer.jl     line=237
mod=DataFrames  var=left_ixs    func=compose_inner_table        sig=Tuple{typeof(DataFrames.compose_inner_table), DataFrames.DataFrameJoiner, Bool, Union{AbstractString, Function, Symbol}, Union{AbstractString, Function, Symbol}, Symbol}     file=/Users/kc/JuliaPkgs/DataFrames.jl/src/join/composer.jl     line=237
mod=DataFrames  var=idx_keeprows        func=_combine   sig=Tuple{typeof(DataFrames._combine), DataFrames.GroupedDataFrame, Vector{Any}, Vector{Bool}, Vararg{Bool, 4}}      file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl     line=665
mod=DataFrames  var=first       func=_combine_with_first        sig=Tuple{typeof(DataFrames._combine_with_first), Ref{Any}, Ref{Any}, DataFrames.GroupedDataFrame, Ref{Any}, Bool, Vector{Int64}, Bool}      file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/complextransforms.jl     line=24
mod=DataFrames  var=drop        func=_deleteat!_helper  sig=Tuple{typeof(DataFrames._deleteat!_helper), DataFrames.DataFrame, Any}   file=/Users/kc/JuliaPkgs/DataFrames.jl/src/dataframe/dataframe.jl       line=897
mod=DataFrames  var=reduce_or!  func=row_group_slots!   sig=Tuple{typeof(DataFrames.row_group_slots!), NTuple{N, AbstractVector}, NTuple{N, AbstractVector}, NTuple{N, Union{Missings.EachReplaceMissing{<:AbstractVector{<:Union{Missing, Real}}}, AbstractVector{<:Real}}}, Val{false}, Vector{Int64}, Bool, Bool, Bool} where N        file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/utils.jl line=265
mod=DataFrames  var=metacol     func=_combine_process_pair_symbol       sig=Tuple{typeof(DataFrames._combine_process_pair_symbol), Bool, DataFrames.GroupedDataFrame, Dict{Symbol, Tuple{Bool, Int64}}, Vector{DataFrames.TransformationResult}, Ref{Vector{Int64}}, Symbol, Bool, Ref{Any}, Ref{Any}, Ref{Any}, Bool, Ref{Any}}  file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl     line=423
mod=DataFrames  var=outcols     func=_combine_rows_with_first!  sig=Tuple{typeof(DataFrames._combine_rows_with_first!), Ref{Any}, Ref{Any}, Ref{Any}, DataFrames.GroupedDataFrame, Ref{Any}, Ref{Any}, Bool, Bool}   file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/complextransforms.jl     line=243
mod=DataFrames  var=ngroups     func=#subset!#645       sig=Tuple{DataFrames.var"##subset!#645", Bool, Bool, Bool, typeof(DataFrames.subset!), DataFrames.GroupedDataFrame, Vararg{Any}}     file=/Users/kc/JuliaPkgs/DataFrames.jl/src/abstractdataframe/subset.jl       line=480
mod=DataFrames  var=newoutcols  func=_combine_rows_with_first_task!     sig=Tuple{typeof(DataFrames._combine_rows_with_first_task!), Integer, Integer, Integer, Integer, NTuple{var"#s659", AbstractVector} where var"#s659", Ref{NTuple{var"#s658", AbstractVector} where var"#s658"}, AbstractVector{Bool}, ReentrantLock, Union{Function, Type}, DataFrames.GroupedDataFrame, AbstractVector{<:Integer}, AbstractVector{<:Integer}, Union{Nothing, Tuple, NamedTuple, AbstractVector}, NTuple{var"#s140", Symbol} where var"#s140", DataFrames.FirstColCount}    file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/complextransforms.jl     line=122
mod=DataFrames  var=eltys       func=_combine_tables_with_first!        sig=Tuple{typeof(DataFrames._combine_tables_with_first!), Union{DataFrames.AbstractDataFrame, NamedTuple{<:Any, <:Tuple{Vararg{AbstractVector}}}}, NTuple{N, AbstractVector}, Vector{Int64}, Integer, Integer, Union{Function, Type}, DataFrames.GroupedDataFrame, Union{Nothing, Tuple, NamedTuple, AbstractVector}, NTuple{N, Symbol}, DataFrames.FirstColCount} where N     file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/complextransforms.jl     line=355
mod=DataFrames  var=col func=#reduce#660        sig=Tuple{DataFrames.var"##reduce#660", Union{AbstractVector{Symbol}, Symbol, AbstractVector{<:AbstractString}}, Union{Nothing, AbstractString, Symbol, Pair{<:Union{AbstractString, Symbol}, <:AbstractVector}}, DataFrames.AbstractDataFrame, typeof(reduce), typeof(vcat), Union{AbstractVector{DataFrames.AbstractDataFrame}, AbstractVector{DataFrames.DataFrame}, AbstractVector{DataFrames.SubDataFrame}, AbstractVector{Union{DataFrames.DataFrame, DataFrames.SubDataFrame}}, Tuple{DataFrames.AbstractDataFrame, Vararg{DataFrames.AbstractDataFrame}}}}       file=/Users/kc/JuliaPkgs/DataFrames.jl/src/abstractdataframe/iteration.jl       line=694
mod=DataFrames  var=len func=_  sig=Tuple{DataFrames.var"#_#186#188", Bool, Type{DataFrames.DataFrame}, Union{Vector{Any}, Vector{AbstractVector}}, DataFrames.Index}        file=/Users/kc/JuliaPkgs/DataFrames.jl/src/dataframe/dataframe.jl    line=193
mod=DataFrames  var=predefined_funs     func=_describe  sig=Tuple{typeof(DataFrames._describe), DataFrames.AbstractDataFrame, AbstractVector}        file=/Users/kc/JuliaPkgs/DataFrames.jl/src/abstractdataframe/abstractdataframe.jl   line=699
mod=DataFrames  var=idx func=_combine_process_callable  sig=Tuple{typeof(DataFrames._combine_process_callable), Ref{Any}, Bool, DataFrames.AbstractDataFrame, DataFrames.GroupedDataFrame, Dict{Symbol, Tuple{Bool, Int64}}, Vector{DataFrames.TransformationResult}, Ref{Vector{Int64}}, Bool}   file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl     line=371
mod=DataFrames  var=out_col_name        func=_combine_process_pair_astable      sig=Tuple{typeof(DataFrames._combine_process_pair_astable), Bool, DataFrames.GroupedDataFrame, Dict{Symbol, Tuple{Bool, Int64}}, Vector{DataFrames.TransformationResult}, Ref{Vector{Int64}}, Union{Type{DataFrames.AsTable}, AbstractVector{Symbol}}, Bool, Ref{Any}, Ref{Any}, Ref{Any}, Bool}       file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl        line=511
mod=DataFrames  var=nms func=_combine_process_pair_astable      sig=Tuple{typeof(DataFrames._combine_process_pair_astable), Bool, DataFrames.GroupedDataFrame, Dict{Symbol, Tuple{Bool, Int64}}, Vector{DataFrames.TransformationResult}, Ref{Vector{Int64}}, Union{Type{DataFrames.AsTable}, AbstractVector{Symbol}}, Bool, Ref{Any}, Ref{Any}, Ref{Any}, Bool}       file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl        line=511
mod=DataFrames  var=outcols     func=_combine_process_pair_astable      sig=Tuple{typeof(DataFrames._combine_process_pair_astable), Bool, DataFrames.GroupedDataFrame, Dict{Symbol, Tuple{Bool, Int64}}, Vector{DataFrames.TransformationResult}, Ref{Vector{Int64}}, Union{Type{DataFrames.AsTable}, AbstractVector{Symbol}}, Bool, Ref{Any}, Ref{Any}, Ref{Any}, Bool}       file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl        line=511
mod=DataFrames  var=idx func=_combine_process_pair_astable      sig=Tuple{typeof(DataFrames._combine_process_pair_astable), Bool, DataFrames.GroupedDataFrame, Dict{Symbol, Tuple{Bool, Int64}}, Vector{DataFrames.TransformationResult}, Ref{Vector{Int64}}, Union{Type{DataFrames.AsTable}, AbstractVector{Symbol}}, Bool, Ref{Any}, Ref{Any}, Ref{Any}, Bool}       file=/Users/kc/JuliaPkgs/DataFrames.jl/src/groupeddataframe/splitapplycombine.jl        line=511

KristofferC · 2025-12-25T15:43:18Z

@aviatesk maybe you have some thoughts about this? I guess this is kind of the same as https://github.com/aviatesk/JET.jl/blob/cf77ed77e46b1a3bda92494818792272269d1d1a/src/analyzers/optanalyzer.jl#L276-L306? Is there a way to only run the CapturedVariableReport "pass" to get an output similar to above? I like how this doesn't have much "noise".

aviatesk · 2025-12-25T18:56:06Z

Sure, we can definitely provide that kind of analysis as a special analyzer for JET.jl. Right now, JET only works with v1.12, but maybe we want to give it a shot?

aviatesk · 2025-12-25T19:04:32Z

So you can do something like

using JET

struct CapturedVariableFilter{RC<:JET.ReportConfig}
    inner::RC
end
function CapturedVariableFilter(; target_modules = nothing, ignored_modules = nothing)
    CapturedVariableFilter(JET.ReportConfig(target_modules, ignored_modules))
end

function JET.configured_reports(config::CapturedVariableFilter, reports::Vector{JET.InferenceErrorReport})
    reports = filter(r->r isa JET.CapturedVariableReport, reports)
    return JET.configured_reports(config.inner, reports)
end

julia> function func(x)
           local y
           f = function ()
               y = x
           end
           return y
       end;

julia> report_opt(func, (Int,), report_config=CapturedVariableFilter())
═════ 1 possible error found ═════
┌ func(x::Int64) @ Main ./REPL[4]:2
│ captured variable `y` detected
└────────────────────

julia> using LibGit2

julia> report_opt(LibGit2.branch!, (LibGit2.GitRepo,String); report_config=CapturedVariableFilter())
═════ 1 possible error found ═════
┌ branch!(repo::GitRepo, branch_name::String) @ LibGit2 /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/usr/share/julia/stdlib/v1.12/LibGit2/src/LibGit2.jl:405
│┌ branch!(repo::GitRepo, branch_name::String, commit::String) @ LibGit2 /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/usr/share/julia/stdlib/v1.12/LibGit2/src/LibGit2.jl:405
││┌ branch!(repo::GitRepo, branch_name::String, commit::String; track::String, force::Bool, set_head::Bool) @ LibGit2 /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/usr/share/julia/stdlib/v1.12/LibGit2/src/LibGit2.jl:411
│││ captured variable `branch_ref` detected
││└────────────────────

aviatesk · 2025-12-25T19:17:38Z

One thing to note is that report_opt, by default, doesn't report these kinds of performance issues for calls to abstract signatures to reduce noise (because dynamic dispatch would be reported at the callsite anyway instead). However, if your script, like in this PR, traverses methods and performs a comprehensive analysis, this tuning might not be useful since our focus is only on captured variables.
We can avoid that problem by specifying skip_noncompileable_calls=true:

julia> report_opt(LibGit2.branch!, (LibGit2.GitRepo,AbstractString); report_config=CapturedVariableFilter())
No errors detected


julia> report_opt(LibGit2.branch!, (LibGit2.GitRepo,AbstractString); report_config=CapturedVariableFilter(), skip_noncompileable_calls=false)
═════ 1 possible error found ═════
┌ branch!(repo::GitRepo, branch_name::AbstractString) @ LibGit2 /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/usr/share/julia/stdlib/v1.12/LibGit2/src/LibGit2.jl:405
│┌ branch!(repo::GitRepo, branch_name::AbstractString, commit::String) @ LibGit2 /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/usr/share/julia/stdlib/v1.12/LibGit2/src/LibGit2.jl:405
││┌ branch!(repo::GitRepo, branch_name::AbstractString, commit::String; track::String, force::Bool, set_head::Bool) @ LibGit2 /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/usr/share/julia/stdlib/v1.12/LibGit2/src/LibGit2.jl:411
│││ captured variable `branch_ref` detected
││└────────────────────

KristofferC · 2025-12-25T20:14:23Z

I guess closure boxes are a bit special since you don't even need types to find them so you can just blast through methods and look at the lowered code (like what this PR does).

aviatesk · 2025-12-26T09:45:44Z

Yeah I think JET might be too much just to find closure boxes.

…0478

fingolfin · 2025-12-27T23:35:00Z

Fun! How about using PrettyTables to render the output?

Also, may I suggest merging file and line into a single FILE:LINE output? Many terminals allow clicking (possibly together with a modifier key like cmd or ctrl) on such an "enriched" path to directly jump to that location in an editor.

…0478 (#189)

Uses JuliaLang/julia#60478 to find `Core.Box` entries in the package and remove them. After this, there are no such closure boxes in the package.

Found using the script in JuliaLang/julia#60478

fingolfin · 2025-12-29T14:34:22Z

contrib/scan-closure-boxes.jl

+    Base.visit(Core.methodtable) do m
+        scan_method!(lines, m, modules)
+    end
+    sort!(lines, by = entry -> entry.mod)


The sorting is very unstable, how about using this instead (it works well for me)

Suggested change

sort!(lines, by = entry -> entry.mod)

sort!(lines, by = entry -> (entry.mod, entry.func, entry.var))

vtjnash · 2025-12-29T14:59:21Z

The improvements derived from this seem like a good idea. However, I question whether it is useful to merge this into contrib, or merely leave it as a closed PR for historical reference.

KristofferC · 2025-12-29T16:31:46Z

Yeah, I can make it a Pkg app or something instead.

I used JuliaLang/julia#60478 to find all the `Core.Box` instances in the package and then fix them.

Found using the script in JuliaLang/julia#60478

Uses JuliaLang/julia#60478 to find `Core.Box` entries in the package and remove them. After this, there are no such closure boxes in the package.

KristofferC · 2026-01-12T11:51:46Z

I like Test.detect_core_boxes. I will try shift this PR to that.

Detected using script from JuliaLang/julia#60478 This was the only Core.Box detected in VortexPasta.

KristofferC · 2026-01-12T12:59:12Z

stdlib/Test/src/Test.jl

                             allowed_undefineds=nothing)
    @nospecialize mods
    ambs = Set{Method}()
-    mods = collect(mods)::Vector{Module}


julia> Test.detect_unbound_args() ERROR: TypeError: in typeassert, expected Vector{Module}, got a value of type Vector{Union{}}

KristofferC · 2026-01-12T12:59:47Z

It is now in Test.

stdlib/Test/src/Test.jl

Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>

KristofferC · 2026-01-13T11:48:46Z

I dunno if the all_modules version is needed but it is something I often want myself at least and there isn't really any good public way of getting all loaded modules I think.

KristofferC · 2026-01-13T17:23:39Z

With the script, it was very easy to get the code_warntype of the method. Not equally easy now. You can do

julia> m, vars = first(Test.detect_closure_boxes(JuliaLowering))
_expand_ast_tree(ctx, srcref, tree) @ JuliaLowering ~/julia/JuliaLowering/src/ast.jl:235 => [:srcref]

julia> m
_expand_ast_tree(ctx, srcref, tree)
     @ JuliaLowering ~/julia/JuliaLowering/src/ast.jl:235

julia> Base.uncompressed_ast(m)
CodeInfo(
     @ /home/kc/julia/JuliaLowering/src/ast.jl:236 within `unknown scope`
1 ──        srcref@_43 = srcref@_3
│    %2   = srcref@_43
│           srcref@_43 = Core.Box(%2)
│           Core.NewvarNode(:(#1))
...

but that doesn't have the nice code_warntype printing. For that you can do something ugly like


julia> function _code_warntype(m::Method; kwargs...)
           sig = m.sig.parameters
           f = sig[1].instance
           argtypes = Tuple{sig[2:end]...}
           code_warntype(f, argtypes; kwargs...)
       end
_code_warntype (generic function with 1 method)

julia> _code_warntype(m)
MethodInstance for JuliaLowering._expand_ast_tree(::Any, ::Any, ::Any)
  from _expand_ast_tree(ctx, srcref, tree) @ JuliaLowering ~/julia/JuliaLowering/src/ast.jl:235
Arguments
  #self#::Core.Const(JuliaLowering._expand_ast_tree)
  ctx::Any
  srcref@_3::Any
  tree::Any

Would be nice to have an easy way to get the warn type printout from the results of the detect function.

giordano · 2026-01-13T22:41:47Z

Can you not store the tuple of the signature, like you had in the script?

nsajko · 2026-01-27T06:07:21Z

stdlib/Test/src/Test.jl

    @nospecialize
    ambs = Set{Tuple{Method,Method}}()
-    mods = collect(mods)::Vector{Module}
+    mods = Module[mods...]


Unrelated bugfix, should be separated out into independent PR and backported to v1.10, v1.12, v1.13?

KristofferC · 2026-01-27T16:33:51Z

With the newish argument type deduction for @code_warntype it is actually quite easy to copy paste the output of the method definition printouts to it so I think this API is ok.

Changes recursive closures into proper methods. Best to review without whitespace. Found via #60478: ``` julia> Test.detect_closure_boxes_all_modules() 8-element Vector{Pair{Method, Vector{Symbol}}}: prune(graph1_a::Base.JuliaSyntax.SyntaxGraph, entrypoints_a::Vector{Int64}) @ Base.JuliaSyntax /JuliaSyntax/src/porcelain/syntax_graph.jl:816 => [:get_resolved!] _stm_check_usage(pats::Expr) @ Base.JuliaSyntax /JuliaSyntax/src/porcelain/syntax_graph.jl:1095 => [:_stm_check_pattern] ```

Uses JuliaLang/julia#60478 to find `Core.Box` entries in the package and remove them. After this, there are no such closure boxes in the package.

) Follow-up to #60478

KristofferC mentioned this pull request Dec 25, 2025

A list of Core.Box in Base and stdlibs #60479

Open

KristofferC changed the title ~~add a vibe coded script to contrib that checks for closures boxes in loaded code~~ add a vibe coded script to contrib that checks for closure boxes in loaded code Dec 25, 2025

KristofferC added a commit to JuliaIO/Tar.jl that referenced this pull request Dec 26, 2025

avoid the remaining Core.Box in the package using JuliaLang/julia#6…

630ea89

…0478

KristofferC mentioned this pull request Dec 26, 2025

get rid of Core.Box in the package JuliaLang/StyledStrings.jl#130

Merged

longemen3000 added a commit to ClapeyronThermo/Clapeyron.jl that referenced this pull request Dec 29, 2025

reduce boxing variables (using JuliaLang/julia#60478)

7580968

KristofferC added a commit to JuliaIO/Tar.jl that referenced this pull request Dec 29, 2025

avoid the remaining Core.Box in the package using JuliaLang/julia#6…

10e4e96

…0478 (#189)

KristofferC added a commit to Ferrite-FEM/Ferrite.jl that referenced this pull request Dec 29, 2025

avoid Core.Box in the package

2052458

Uses JuliaLang/julia#60478 to find `Core.Box` entries in the package and remove them. After this, there are no such closure boxes in the package.

KristofferC mentioned this pull request Dec 29, 2025

avoid Core.Box in the package Ferrite-FEM/Ferrite.jl#1265

Merged

KristofferC added a commit to JuliaLang/Pkg.jl that referenced this pull request Dec 29, 2025

fix Core.Boxes in the package by

a22da0c

Found using the script in JuliaLang/julia#60478

KristofferC mentioned this pull request Dec 29, 2025

fix Core.Boxes in the package JuliaLang/Pkg.jl#4582

Merged

fingolfin reviewed Dec 29, 2025

View reviewed changes

KristofferC added a commit to KristofferC/DataFrames.jl that referenced this pull request Dec 30, 2025

avoid Core.Box in the package

54f7a45

I used JuliaLang/julia#60478 to find all the `Core.Box` instances in the package and then fix them.

KristofferC mentioned this pull request Dec 30, 2025

avoid Core.Box in the package JuliaData/DataFrames.jl#3520

Merged

KristofferC added a commit to JuliaLang/Pkg.jl that referenced this pull request Dec 30, 2025

fix Core.Boxes in the package by

acba491

Found using the script in JuliaLang/julia#60478

KristofferC added a commit to JuliaLang/Pkg.jl that referenced this pull request Dec 30, 2025

fix Core.Boxes in the package by

31c855b

Found using the script in JuliaLang/julia#60478

KristofferC force-pushed the kc/vibe_boxes branch from 606e0a1 to bfee356 Compare December 30, 2025 12:25

KristofferC added a commit to JuliaLang/Pkg.jl that referenced this pull request Dec 30, 2025

fix Core.Boxes in the package by

b960391

Found using the script in JuliaLang/julia#60478

KristofferC added a commit to Ferrite-FEM/Ferrite.jl that referenced this pull request Dec 30, 2025

avoid Core.Box in the package

1947bd2

Uses JuliaLang/julia#60478 to find `Core.Box` entries in the package and remove them. After this, there are no such closure boxes in the package.

hz-xiaxz mentioned this pull request Jan 1, 2026

Eliminate all Core.Box captures to reduce latency and allocations MakieOrg/Makie.jl#5475

Merged

5 tasks

asinghvi17 mentioned this pull request Jan 1, 2026

Analyse boxing using Kristoffer's script JuliaGeo/GeometryOps.jl#371

Open

jipolanco added a commit to jipolanco/VortexPasta.jl that referenced this pull request Jan 12, 2026

Remove Core.Box in write_vtkhdf

3791933

Detected using script from JuliaLang/julia#60478 This was the only Core.Box detected in VortexPasta.

KristofferC force-pushed the kc/vibe_boxes branch from bfee356 to 7d4c437 Compare January 12, 2026 12:57

add a vibe coded script that checks for closures boxes in loaded code

0dc8a09

KristofferC force-pushed the kc/vibe_boxes branch from 7d4c437 to 4cc0b40 Compare January 12, 2026 12:58

KristofferC commented Jan 12, 2026

View reviewed changes

aviatesk reviewed Jan 12, 2026

View reviewed changes

stdlib/Test/src/Test.jl Outdated Show resolved Hide resolved

giordano added the testsystem The unit testing framework and Test stdlib label Jan 12, 2026

giordano changed the title ~~add a vibe coded script to contrib that checks for closure boxes in loaded code~~ add a vibe coded Test.detect_closure_boxes for closure boxes in loaded code Jan 12, 2026

move the contrib script to Test

84ddda0

Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>

KristofferC force-pushed the kc/vibe_boxes branch from 427f15f to 84ddda0 Compare January 12, 2026 16:06

tweaks

c827ab1

add a NEWS entry

1a43609

jwahlstrand mentioned this pull request Jan 17, 2026

Remove Core.Box JuliaGizmos/GtkObservables.jl#79

Merged

ranocha mentioned this pull request Jan 18, 2026

check boxes trixi-framework/Trixi.jl#2743

Open

nsajko reviewed Jan 27, 2026

View reviewed changes

KristofferC mentioned this pull request Jan 27, 2026

get rid of two core boxes in JuliaSyntax #60835

Merged

KristofferC merged commit 1c9ecc2 into master Jan 28, 2026
8 checks passed

KristofferC deleted the kc/vibe_boxes branch January 28, 2026 11:22

fredrikekre pushed a commit to Ferrite-FEM/Ferrite.jl that referenced this pull request Jan 29, 2026

avoid Core.Box in the package (#1265)

d31de82

Uses JuliaLang/julia#60478 to find `Core.Box` entries in the package and remove them. After this, there are no such closure boxes in the package.

thofma mentioned this pull request Feb 3, 2026

Use Test.detect_closure_boxes thofma/Hecke.jl#2167

Open

DilumAluthge mentioned this pull request Feb 21, 2026

Feature request: Add Test.detect_closure_boxes() to the list of default checks JuliaTesting/Aqua.jl#367

Open

DilumAluthge mentioned this pull request Mar 3, 2026

Add Julia compat note for Test.detect_closure_boxes docstrings #61223

Merged

aviatesk pushed a commit that referenced this pull request Mar 4, 2026

Add Julia compat note for Test.detect_closure_boxes docstrings (#61223

74887d0

) Follow-up to #60478

	sort!(lines, by = entry -> entry.mod)
	sort!(lines, by = entry -> (entry.mod, entry.func, entry.var))

Uh oh!

Conversation

KristofferC commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KristofferC commented Dec 25, 2025

Uh oh!

KristofferC commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aviatesk commented Dec 25, 2025

Uh oh!

aviatesk commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aviatesk commented Dec 25, 2025

Uh oh!

KristofferC commented Dec 25, 2025

Uh oh!

aviatesk commented Dec 26, 2025

Uh oh!

fingolfin commented Dec 27, 2025

Uh oh!

fingolfin Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

vtjnash commented Dec 29, 2025

Uh oh!

KristofferC commented Dec 29, 2025

Uh oh!

KristofferC commented Jan 12, 2026

Uh oh!

KristofferC Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

KristofferC commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

KristofferC commented Jan 13, 2026

Uh oh!

KristofferC commented Jan 13, 2026

Uh oh!

giordano commented Jan 13, 2026

Uh oh!

nsajko Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

KristofferC commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

KristofferC commented Dec 25, 2025 •

edited

Loading

KristofferC commented Dec 25, 2025 •

edited

Loading

aviatesk commented Dec 25, 2025 •

edited

Loading

KristofferC commented Jan 12, 2026 •

edited

Loading