Skip to content

Support quadratic constraints#181

Merged
amontoison merged 21 commits intoJuliaSmoothOptimizers:mainfrom
amontoison:quadcon
Jun 21, 2024
Merged

Support quadratic constraints#181
amontoison merged 21 commits intoJuliaSmoothOptimizers:mainfrom
amontoison:quadcon

Conversation

@amontoison
Copy link
Copy Markdown
Member

@amontoison amontoison commented Jun 20, 2024 •
edited
Loading

close #50
close #149
close #150
@tmigot You should be happy now 😃

@amontoison amontoison requested a review from tmigot June 20, 2024 04:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

Package name latest stable
NLSProblems.jl
OptimizationProblems.jl

@amontoison
Copy link
Copy Markdown
Member Author

amontoison commented Jun 20, 2024

@tmigot We should probably add HS61, HS100 and HS219 in NLPModelsTest.jl for more robust tests.

@amontoison amontoison force-pushed the quadcon branch 3 times, most recently from 24709d4 to b391a07 Compare June 20, 2024 19:47
@amontoison amontoison mentioned this pull request Jun 20, 2024
Closed
@amontoison
Copy link
Copy Markdown
Member Author

amontoison commented Jun 21, 2024

If we replace @NLconstraint with @constraint for the quadratic constraints in hs6, hs10, hs11, and hs14, almost all tests pass.
The failing tests are related to this issue: JuliaSmoothOptimizers/NLPModelsTest.jl#109.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.27653% with 80 lines in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (5bb0b82) to head (02317b4).

❗ Current head 02317b4 differs from pull request most recent head f39f1e4

Please upload reports for the commit f39f1e4 to get more accurate results.

Files Patch % Lines
src/utils.jl 57.28% 44 Missing ⚠️
src/moi_nls_model.jl 65.04% 36 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   93.00%   86.94%   -6.07%     
==========================================
  Files           4        5       +1     
  Lines         629      919     +290     
==========================================
+ Hits          585      799     +214     
- Misses         44      120      +76

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmigot tmigot mentioned this pull request Jun 21, 2024
Merged
tmigot
tmigot requested changes Jun 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amontoison ! Thanks for the PR that's great.
I just had minor comments to add some tests.
How did you verify the result?

Comment thread src/utils.jl
Comment thread src/utils.jl
Comment thread test/nlp_problems/hs100.jl
Comment thread src/utils.jl
@tmigot tmigot mentioned this pull request Jun 21, 2024
Closed
tmigot
tmigot approved these changes Jun 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amontoison ! It looks good to me.
I think we just need a problem in NLPModelsTest that has both quadratic and nonlinear constraints.
Let's go for 0.13.0 when you are ready.

@tmigot tmigot mentioned this pull request Jun 21, 2024
Open
@amontoison amontoison merged commit c12dc0c into JuliaSmoothOptimizers:main Jun 21, 2024
@amontoison amontoison deleted the quadcon branch June 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmigot tmigot tmigot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsupported features should error, not warn Improve hess_coord! when y is not provided Add support for quadratic constraints

2 participants

@amontoison @tmigot
⚡