Conversation
- Remove all markdown-link-check-disable HTML comment tags (84 pairs) - Add exclude_path to lychee.toml for archived pages with intentional broken links - Add 10 domain patterns to lychee.toml exclude (3+ occurrence threshold) - Consolidate .lycheeignore: 40 → 11 URLs (remove domains managed in lychee.toml) - Create .claude/rules/link-checking.md: Link exclusion strategy guide - Update .claude/rules/tools.md: Document lychee limitations - Update survey.md with confirmed analysis results This improves maintainability by preventing new links in excluded domains from triggering CI failures, and centralizing domain exclusion in lychee.toml. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
lychee interprets relative paths as file system paths, which conflicts with MkDocs' URL transformation. Since relative links are internal to the site structure and not resolvable by the tool, exclude them from validation. Resolves ~500 false positives from relative path checking. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Lychee was not correctly resolving relative paths in Markdown files (including image references like ../../images/chrome_extension/*.png) because the working directory context was missing. The --base option ensures relative paths are resolved correctly from the repository root. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The --base option in lychee-action now correctly resolves relative paths, so excluding them is unnecessary and would hide bugs in internal links. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…tion
lychee's --root-dir option must be an absolute path (not relative like .)
to properly resolve relative paths in markdown files. In GitHub Actions,
${{ github.workspace }} provides the absolute path to the repository root.
This fixes the issue where relative paths like ../../images/... in
markdown files were being calculated incorrectly, resulting in
file:// URLs missing the docs/ directory prefix.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…match Image paths in markdown are written relative to MkDocs build output (e.g. ../../images/ from archived/outdated_information/), but lychee resolves paths against the source tree where docs/ is the root — causing false negatives for all local file references. Excluding file:// limits lychee to HTTP/HTTPS link validation, which is the intended use case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This archived page contains image paths written for MkDocs build output and likely has stale external links — consistent with the other excluded archived pages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #12021