Merged
Conversation
Member
|
@rrandallcainc looks reasonable to me. |
k4b7
reviewed
Dec 11, 2017
| * to change. Use at your own risk. | ||
| */ | ||
| __parse: generateParseTree, | ||
| __getBuildTree: generateBuildTree, |
Member
There was a problem hiding this comment.
Can you add a warning above this function as well?
added 2 commits
December 10, 2017 19:51
k4b7
approved these changes
Dec 11, 2017
Member
|
Thanks for the PR. |
This was referenced Dec 11, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a user I would like to expose Katex's buildTree for more advanced use cases (like rendering to a custom output other than DOM)
While this thread tracks an intermediate representation, it would be nice if users could leverage what exists in the meantime (with the caveat that it's likely to change).
This PR follows a similar convention to the parseTree in that user's are welcome to use it, but are given an appropriate warning message.