Support multiValueHeaders on Response#129
Merged
jordaneremieff merged 2 commits intoKludex:mainfrom Jun 25, 2020
Merged
Conversation
Collaborator
|
@koxudaxi Looks like a good addition, I will merge this when it is ready. Thanks! |
Collaborator
Author
|
@jordaneremieff By the way, Why CI does not run for this PR? |
Collaborator
|
@koxudaxi thanks. Not sure why it doesn't appear on Github, but the build does run successfully in CI https://travis-ci.org/github/erm/mangum/builds/701506590. I'll try to review this soon then will merge. |
four43
pushed a commit
to four43/mangum
that referenced
this pull request
Mar 27, 2021
* support multiValueHeaders
four43
pushed a commit
to four43/mangum
that referenced
this pull request
Aug 20, 2021
* support multiValueHeaders
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
* support multiValueHeaders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jordaneremieff
I suggest to support
multiValueHeaderson Response.I want to set the same-name cookies.
FastAPI+uvicorncan return same-name cookies.But, Mangum returned only the last cookie. the first cookie is dropped.
Mangum should support
multiValueHeadersto resolve the problem.This change affects a little bit of performance.
If You prefer this PR, then I will add test the code.
How do you think about it?
https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html#api-gateway-simple-proxy-for-lambda-output-format
example
output