Skip to content

Fix duplicate test names preventing test runs. #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordaneremieff merged 2 commits into from
Aug 9, 2020
+5 −30
Merged

Fix duplicate test names preventing test runs. #134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5a5ecb
Fix duplicate test_http_request preventing test runs.
a-feld Aug 8, 2020
192e989
Remove duplicate http response headers test.
a-feld Aug 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 5 additions & 30 deletions tests/test_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import base64
import urllib.parse
import json
import gzip
import json
import urllib.parse

import pytest
from starlette.applications import Starlette
from starlette.middleware.gzip import GZipMiddleware
from starlette.responses import PlainTextResponse

from mangum import Mangum


Expand Down Expand Up @@ -115,7 +116,7 @@ async def app(scope, receive, send):
"raw_path": None,
"root_path": "",
"scheme": "https",
"server": ("test.execute-api.us-west-2.amazonaws.com", 80),
"server": ("test.execute-api.us-west-2.amazonaws.com", 443),
"type": "http",
}
await send(
Expand Down Expand Up @@ -545,7 +546,7 @@ async def app(scope, receive, send):
],
indirect=["mock_http_api_event"],
)
def test_http_request(mock_http_api_event) -> None:
def test_api_request(mock_http_api_event) -> None:
async def app(scope, receive, send):
assert scope == {
"asgi": {"version": "3.0"},
Expand Down Expand Up @@ -632,32 +633,6 @@ async def app(scope, receive, send):
}


@pytest.mark.parametrize("mock_http_event", [["GET", "", None]], indirect=True)
def test_http_response_headers(mock_http_event) -> None:
async def app(scope, receive, send):
assert scope["type"] == "http"
await send(
{
"type": "http.response.start",
"status": 200,
"headers": [[b"x-header-1", b"123"], [b"x-header-2", b"456"]],
}
)
await send({"type": "http.response.body", "body": b"Hello, world!"})

handler = Mangum(app, lifespan="off")

mock_http_event["headers"] = None

response = handler(mock_http_event, {})
assert response == {
"statusCode": 200,
"isBase64Encoded": False,
"headers": {"x-header-1": "123", "x-header-2": "456"},
"body": "Hello, world!",
}


@pytest.mark.parametrize("mock_http_event", [["GET", "", None]], indirect=True)
def test_http_empty_header(mock_http_event) -> None:
async def app(scope, receive, send):
Expand Down
⚡