Only prefix a slash on the api_gateway_base_path if needed#138
Merged
jordaneremieff merged 2 commits intoKludex:mainfrom Sep 28, 2020
Merged
Only prefix a slash on the api_gateway_base_path if needed#138jordaneremieff merged 2 commits intoKludex:mainfrom
jordaneremieff merged 2 commits intoKludex:mainfrom
Conversation
Collaborator
|
@dspatoulas Looks like a good improvement, thanks! Could you code format the adapter file with |
four43
pushed a commit
to four43/mangum
that referenced
this pull request
Mar 27, 2021
* Only prefix a slash on the api_gateway_base_path if needed * Improve readability and compatibility with black python linter Co-authored-by: DJ Spatoulas <djs@knowbe4.com>
four43
pushed a commit
to four43/mangum
that referenced
this pull request
Aug 20, 2021
* Only prefix a slash on the api_gateway_base_path if needed * Improve readability and compatibility with black python linter Co-authored-by: DJ Spatoulas <djs@knowbe4.com>
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
* Only prefix a slash on the api_gateway_base_path if needed * Improve readability and compatibility with black python linter Co-authored-by: DJ Spatoulas <djs@knowbe4.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only appends a prefix to the
api_gw_base_pathif it's not there already to avoid duplicate prefix slashes.Issue: #137
Intended Design Change