Skip to content

AWS Lambda context type hinting #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koxudaxi merged 4 commits into from
Feb 26, 2021
+5 −2
Merged

AWS Lambda context type hinting #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c6eb01
➕ add awslambdaric deps for type checking
ediskandarov-cur Jan 13, 2021
60b769a
🏷️ add type hints for lambda context in handler
ediskandarov-cur Jan 13, 2021
9a15d1c
✅ exclude typing code from coverage
ediskandarov-cur Jan 13, 2021
fe72ca7
➖ remove redundant awslambdaric dependency
ediskandarov-cur Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mangum/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
from mangum.protocols.http import HTTPCycle
from mangum.exceptions import ConfigurationError

if typing.TYPE_CHECKING: # pragma: no cover
from awslambdaric.lambda_context import LambdaContext

DEFAULT_TEXT_MIME_TYPES = [
"application/json",
Expand Down Expand Up @@ -79,7 +81,7 @@ def __post_init__(self, text_mime_types: typing.Optional[typing.List[str]]) -> N
text_mime_types = DEFAULT_TEXT_MIME_TYPES
self.text_mime_types = text_mime_types

def __call__(self, event: dict, context: dict) -> dict:
def __call__(self, event: dict, context: "LambdaContext") -> dict:
self.logger.debug("Event received.")

with ExitStack() as stack:
Expand Down
3 changes: 2 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ moto
mypy
brotli
brotli-asgi
awslambdaric-stubs
# Docs
mkdocs
mkdocs-material
mkdocs-material
⚡