Skip to content

add test to return multiple headers when the multi-value headers opton is enabled in ALB#187

Closed
jurasofish wants to merge 2 commits intoKludex:mainfrom
jurasofish:test_multi_headers_185
Closed

add test to return multiple headers when the multi-value headers opton is enabled in ALB#187
jurasofish wants to merge 2 commits intoKludex:mainfrom
jurasofish:test_multi_headers_185

Conversation

@jurasofish
Copy link
Copy Markdown
Contributor

mangum splits the header response between the headers and multiValueHeaders items.

When the multi-value headers option is enabled all headers must be under multiValueHeaders, as described here https://docs.aws.amazon.com/elasticloadbalancing/latest/application/lambda-functions.html#multi-value-headers.

What mangum produces:

'headers': {'content-type': 'text/plain; charset=utf-8'}, 'multiValueHeaders': {'set-cookie': ['cookie1=cookie1; Secure', 'cookie2=cookie2; Secure']}

What should be produced:

'multiValueHeaders': {'content-type': ['text/plain; charset=utf-8'], 'set-cookie': ['cookie1=cookie1; Secure', 'cookie2=cookie2; Secure']}

@jurasofish jurasofish marked this pull request as ready for review April 20, 2021 02:17
@jordaneremieff
Copy link
Copy Markdown
Collaborator

Hi @jurasofish, are there changes in your draft PR needed to run these tests? Please let me know the statuses and I can review/merge.

@jurasofish
Copy link
Copy Markdown
Contributor Author

Hi @jurasofish, are there changes in your draft PR needed to run these tests? Please let me know the statuses and I can review/merge.

hey, yes, #189 sorts everything out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants