Skip to content

HTTP Gateway V2: Remove use of obsolete multiValueHeaders#216

Merged
jordaneremieff merged 1 commit intoKludex:mainfrom
IlyaSukhanov:http_gateway_v2_response_cookies
Jan 12, 2022
Merged

HTTP Gateway V2: Remove use of obsolete multiValueHeaders#216
jordaneremieff merged 1 commit intoKludex:mainfrom
IlyaSukhanov:http_gateway_v2_response_cookies

Conversation

@IlyaSukhanov
Copy link
Copy Markdown
Contributor

HTTP Gateway V2 drops both the multiValueHeaders and
multiValueQueryStringParameters elements.

With this change:

  • Cookies passed to request and response as cookie element
    containing list of all cookie values.
  • Headers with multiple values are concatenated through comma
    and passed under Headers element instead of the obsolete
    multiValueHeaders.

https://medium.com/@lancers/amazon-api-gateway-explaining-lambda-payload-version-2-0-in-http-api-24b0b4db5d36
https://aws.amazon.com/blogs/compute/building-better-apis-http-apis-now-generally-available/

Addresses issue #215.

HTTP Gateway V2 drops both the multiValueHeaders and
multiValueQueryStringParameters elements.

With this change:
* Cookies passed to request and response as cookie element
  containing list of all cookie values.
* Headers with multiple values are concatenated through comma
  and passed under Headers element instead of the obsolete
  multiValueHeaders.

https://medium.com/@lancers/amazon-api-gateway-explaining-lambda-payload-version-2-0-in-http-api-24b0b4db5d36
https://aws.amazon.com/blogs/compute/building-better-apis-http-apis-now-generally-available/

Addresses issue Kludex#215.
@jordaneremieff
Copy link
Copy Markdown
Collaborator

@koxudaxi if you have availability, could you review this? I am currently stuck overseas due to COVID, and won’t be able to properly review anything for a few weeks yet.

@koxudaxi
Copy link
Copy Markdown
Collaborator

@IlyaSukhanov
Thank you for creating the PR.
I have checked your code. And I confirmed multiValueHeaders is removed in V2.

@jordaneremieff
I feel The PR is very good. we can merge it.

@jordaneremieff jordaneremieff merged commit a589465 into Kludex:main Jan 12, 2022
@IlyaSukhanov
Copy link
Copy Markdown
Contributor Author

@jordaneremieff Thank you! I hope you're able to get back soon from your travels.

@koxudaxi appreciate the review.

@jordaneremieff
Copy link
Copy Markdown
Collaborator

Thanks for the PR @IlyaSukhanov and the well wishes - I've fortunately been able to return home just today. 🙂 And thank you for taking the time to review this @koxudaxi. 👍

I'm still getting adjusted back into my routines and refreshing myself on the state of this project, but will try to do a release sometime soon.

khamaileon pushed a commit to khamaileon/mangum that referenced this pull request Jan 13, 2024
HTTP Gateway V2 drops both the multiValueHeaders and
multiValueQueryStringParameters elements.

With this change:
* Cookies passed to request and response as cookie element
  containing list of all cookie values.
* Headers with multiple values are concatenated through comma
  and passed under Headers element instead of the obsolete
  multiValueHeaders.

https://medium.com/@lancers/amazon-api-gateway-explaining-lambda-payload-version-2-0-in-http-api-24b0b4db5d36
https://aws.amazon.com/blogs/compute/building-better-apis-http-apis-now-generally-available/

Addresses issue Kludex#215.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants