Fix aws_api_gateway handler not accepting combined headers and multiValueHeaders#229
Merged
jordaneremieff merged 6 commits intoKludex:mainfrom Feb 4, 2022
Feriixu:main
Merged
Fix aws_api_gateway handler not accepting combined headers and multiValueHeaders#229jordaneremieff merged 6 commits intoKludex:mainfrom Feriixu:main
jordaneremieff merged 6 commits intoKludex:mainfrom
Feriixu:main
Conversation
Contributor
Author
|
And please create a release, so this gets pushed to PyPi 😄 |
Collaborator
Yep this makes sense, thanks. If you fix the tests I'll merge and see about a release. |
Contributor
Author
|
That should fix it. |
There was a single space where there shouldn't have been one, so the assert failed.
Lines were too long
Contributor
Author
|
The linters are happy now, and I fixed the tests. You may want to squash that mess (lol). |
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
…alueHeaders (Kludex#229) * Fix aws_api_gateway handler not accepting combined headers and multiValueHeaders * Fix test_aws_api_gateway.py::test_aws_api_gateway_scope_basic * Formatting * Fix test_aws_api_gateway_scope_basic again There was a single space where there shouldn't have been one, so the assert failed. * More reformatting Lines were too long * Okay now the linters should be happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling a Lambda via a AWS API Gateway, you are supposed to be able to use both normal headers and "multiValueHeaders" as described here: "Multi-value headers as well as single-value headers and parameters can be combined in the same requests and responses."
I fixed this by simply checking for both keys in the event dict and updating the resulting headers dict first with the normal headers and then with the multiValueHeaders, so they still take precedence.