Added text_mime_types argument

[georgebv]

Added optional text_mime_types argument to:

• Mangum adapter's __init__ method
• handle_base64_response_body function (this function is the target recipient of the text_mime_types list)

This argument is optional and by default references the same DEFAULT_TEXT_MIME_TYPES list.

WARNING: old solutions involving editing the DEFAULT_TEXT_MIME_TYPES list are now broken because this list was moved from mangum/handlers/utils.py to mangum/adapter.py.

resolves #275

[jordaneremieff]

Thanks @georgebv! Just a few requests related to how the configuration and default are organized now.

The original intention of the LambdaConfig was for things like this to avoid having to pass things explicitly to the handler __call__ methods.

Also, could you add one new test demonstrating the new configuration being used?

[georgebv]

Regarding new tests, I wasn't sure where to put this. Technically, this is an integration test where we use adapter itself. But, since handlers are so different, I put the test to API gateway.

[jordaneremieff]

Regarding new tests, I wasn't sure where to put this. Technically, this is an integration test where we use adapter itself. But, since handlers are so different, I put the test to API gateway.

Yep that’s fine, thank you.

[jordaneremieff]

Hi @georgebv, are you still interested in working on this feature?

[georgebv]

@jordaneremieff absolutely, didn't have time these last 2 weeks - was planning to wrap this up in the next few days

[georgebv]

I had to bring back the [*DEFAULT_TEXT_MIME_TYPES] because tests testing it were failing due to global list being modified by handler.config["text_mime_types"].append(content_type.decode()). Let me know if you have a better solution for this, but I think this is the best way to handle this - we use global list as default and we make a copy of it on adapter instantiation. Without this the __init__ method of Mangum would have this side effect of mutating global object.

[jordaneremieff]

I had to bring back the [*DEFAULT_TEXT_MIME_TYPES] because tests testing it were failing due to global list being modified by handler.config["text_mime_types"].append(content_type.decode()).

Yep, that's fine then, thanks for explaining.

[jordaneremieff]

Looks good, great work!