This repository was archived by the owner on Mar 11, 2022. It is now read-only.
Include template-processors images in the testing phase in DEVELOPMENT.md#228
Merged
seanmalloy merged 2 commits intomasterfrom Jan 2, 2020
Merged
Include template-processors images in the testing phase in DEVELOPMENT.md#228seanmalloy merged 2 commits intomasterfrom
seanmalloy merged 2 commits intomasterfrom
Conversation
Include building and deployment of templates-processors images in the testing phase. Do it this way because a template-processor image is tightly tied with eunomia-operator and there is little sense in testing one without the other.
By doing this there will be no error of an unbound variable if TRAVIS_TAG is not set.
seanmalloy
approved these changes
Jan 2, 2020
akavel
reviewed
Jan 3, 2020
Comment on lines
+29
to
+41
| if [[ ! "${1:-}" ]]; then | ||
| usage | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "$1" == minikube ]]; then | ||
| eval $(minikube docker-env) | ||
| elif [[ "$1" == minishift ]]; then | ||
| eval $(minishift docker-env) | ||
| else | ||
| usage | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Possible simplification:
case "${1:-}" in
minikube) eval $(minikube docker-env);;
minishift) eval $(minishift docker-env);;
*)
usage
exit 1
;;
esac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include building and deployment of templates-processors images in the
testing phase. Do it this way because a template-processor image is
tightly tied with eunomia-operator and there is little sense in testing
one without the other.
Doesn't fix any issue - this PR addresses the discussion from #200 (comment)
Type of change
Checklist