Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Set CA_BUNDLE and SERVICE_CA_BUNDLE to path#266

Merged
seanmalloy merged 2 commits intomasterfrom
issue-152
Jan 22, 2020
Merged

Set CA_BUNDLE and SERVICE_CA_BUNDLE to path#266
seanmalloy merged 2 commits intomasterfrom
issue-152

Conversation

@vinny-sabatini
Copy link
Copy Markdown
Member

@vinny-sabatini vinny-sabatini commented Jan 22, 2020

Description

CA_BUNDLE and SERVICE_CA_BUNDLE were set to the base64 encoded content of each certificate.
This change sets those environment variables to the path of each file allowing template processors to utilize the certificate bundles however they need to.

Fixes #152

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Unit tests and e2e tests updated
  • Documentation updated

Vinny Sabatini added 2 commits January 22, 2020 14:46
`CA_BUNDLE` and `SERVICE_CA_BUNDLE` were set to the base64 encoded
content of each certificate. This change sets those environment
variables to the path of each file allowing template processors to
utilize the certificate bundles however they need to.

Fixes #152
@vinny-sabatini
Copy link
Copy Markdown
Member Author

At this point, I don't believe the CA_BUNDLE or SERVICE_CA_BUNDLE environment variables are used in any of our template processors, so I'm not positive how we want to test this.
I am open to other suggestions if people have ideas!

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2020

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #266   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           1      1           
  Lines          52     52           
=====================================
  Misses         52     52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1345a37...408b3df. Read the comment docs.

@seanmalloy seanmalloy added this to the v0.1.2 milestone Jan 22, 2020
@seanmalloy seanmalloy merged commit cee8065 into master Jan 22, 2020
@seanmalloy seanmalloy deleted the issue-152 branch January 22, 2020 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

The kubectl describe command in discoverEnvironment.sh is failing

2 participants