This repository was archived by the owner on Mar 11, 2022. It is now read-only.
Add kubernetes liveliness(health) check uri#268
Merged
seanmalloy merged 1 commit intomasterfrom Jan 23, 2020
Merged
Conversation
Add liveliness endpoint at /healthz for eunomia-operatator and add livenessProbe to deployment definition. This is done in order for kubernetes to know when pod is healthy or need to be restarted. Signed-off-by: Karol Krawczyk <kkrawczyk@griddynamics.com>
karolkrawczyk
force-pushed
the
issue-248
branch
from
4f0ca1d to
91ae930
Compare
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 1 1
Lines 52 52
=====================================
Misses 52 52Continue to review full report at Codecov.
|
seanmalloy
approved these changes
Jan 23, 2020
akavel
reviewed
Jan 24, 2020
| handler.WebhookHandler(w, r, gitopsconfig.NewReconciler(mgr)) | ||
| }) | ||
|
|
||
| mux.HandleFunc("/healthz", func(w http.ResponseWriter, _ *http.Request) { |
There was a problem hiding this comment.
Nice, the _ is a fine touch!
Also, huge thanks for including the "why" in the commit message. Highly appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add liveliness endpoint at /healthz for eunomia-operatator and add
livenessProbe to deployment definition. This is done in order for
kubernetes to know when pod is healthy or need to be restarted.
Fixes #248
Type of change
Checklist