This repository was archived by the owner on Mar 11, 2022. It is now read-only.
cmd/manager: expose version info#284
Merged
seanmalloy merged 4 commits intoKohlsTechnology:masterfrom Feb 6, 2020
Merged
Conversation
added 3 commits
February 4, 2020 15:34
…ology#260) Add a Prometheus-formatted metric which provides an easy way to check version of eunomia running. Issue KohlsTechnology#260.
…chnology#260) In issue templates, show a command that can be used to easily retrieve eunomia version from a cluster. Issue KohlsTechnology#260.
Author
|
|
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 1 1
Lines 52 52
=====================================
Misses 52 52Continue to review full report at Codecov.
|
vinny-sabatini
previously approved these changes
Feb 5, 2020
Member
vinny-sabatini
left a comment
vinny-sabatini
left a comment
There was a problem hiding this comment.
LGTM
In the future I think it might be useful to include the git SHA1 in here too.
seanmalloy
suggested changes
Feb 6, 2020
Contributor
seanmalloy
left a comment
seanmalloy
left a comment
There was a problem hiding this comment.
Please also add version.Branch, version.BuildDate, and version.GitSHA1.
Lines 21 to 23 in ef5737a
When printing eunomia version (via Prometheus metrics and --version flag), also print build details (date, git SHA, branch). This extra information may also be helpful when debugging.
seanmalloy
approved these changes
Feb 6, 2020
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Prometheus metric exposing eunomia version, and a command-line flag doing the same. This makes it easy to find out what version of eunomia is running in a cluster (via metric) or is available for running (via flag).
Also, in issue templates, show a command that can be used to easily retrieve eunomia version from a cluster. This is intended to help issue reporters give us precise information with as little effort on their side as possible.
Fixes #260
Type of change
Checklist