This repository was archived by the owner on Mar 11, 2022. It is now read-only.
pkg/controller/gitopsconfig: change Finalizers with ResourceDeletionMode#313
Merged
seanmalloy merged 3 commits intoKohlsTechnology:masterfrom Mar 12, 2020
Merged
pkg/controller/gitopsconfig: change Finalizers with ResourceDeletionMode#313seanmalloy merged 3 commits intoKohlsTechnology:masterfrom
seanmalloy merged 3 commits intoKohlsTechnology:masterfrom
Conversation
…logy#272) The GitOpsConfig object used in controller_test.go had `.Finalizers` field empty, not in sync with `.Spec.ResourceDeletionMode="Delete"` field. This commit fixes `.Finalizers` value, which will become important for later commit. Related to KohlsTechnology#272.
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=========================================
+ Coverage 21.57% 24.4% +2.82%
=========================================
Files 6 6
Lines 482 500 +18
=========================================
+ Hits 104 122 +18
+ Misses 353 352 -1
- Partials 25 26 +1
Continue to review full report at Codecov.
|
When .Spec.ResourceDeletionMode is changed, make this change effective by changing the .Finalizers field. Previously, .Finalizers was never changed after GitOpsConfig was marked as initialized. Fixes KohlsTechnology#272. Also, increase a timeout in a test slightly, it was failing for me as too short.
Increase a timeout in attempt at making CI pass more reliably - see a timeout on l.232 in: https://travis-ci.com/KohlsTechnology/eunomia/jobs/296112485#L2449
seanmalloy
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When .Spec.ResourceDeletionMode is changed, make this change effective
by changing the .Finalizers field. Previously, .Finalizers was never
changed after GitOpsConfig was marked as initialized.
Fixes #272.
Also, increase a timeout in a test slightly, it was failing for me as
Type of change
Checklist
Documentation updated- N/A