Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

add support for submodules#333

Merged
seanmalloy merged 2 commits intomasterfrom
submodules
Apr 13, 2020
Merged

add support for submodules#333
seanmalloy merged 2 commits intomasterfrom
submodules

Conversation

@Smiley73
Copy link
Copy Markdown
Contributor

@Smiley73 Smiley73 commented Apr 8, 2020

Description

Add the ability to have repositories with submodules, which point at a specific branch instead of a commit. This allows the separation of helm charts that need to read files (e.g. configmaps) from their configuration.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Unit tests and e2e tests updated
  • Documentation updated

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2020

Codecov Report

Merging #333 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   24.67%   24.67%           
=======================================
  Files           6        6           
  Lines         531      531           
=======================================
  Hits          131      131           
  Misses        370      370           
  Partials       30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e93df...78c2655. Read the comment docs.

@seanmalloy
Copy link
Copy Markdown
Contributor

@Smiley73 the changes look good. Can you create a git submodules example in the examples directory and then run the new git submodules example in the scripts/e2e-test.sh script?

@Smiley73
Copy link
Copy Markdown
Contributor Author

@seanmalloy test has been added.

Comment thread README.md Outdated
Co-Authored-By: Sean Malloy <sean.malloy@kohls.com>
@seanmalloy seanmalloy merged commit 85115d2 into master Apr 13, 2020
@seanmalloy seanmalloy deleted the submodules branch April 13, 2020 19:33
@seanmalloy seanmalloy added this to the v0.1.7 milestone Jul 28, 2020
@seanmalloy seanmalloy added the enhancement New feature or request label Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants